-
-
Notifications
You must be signed in to change notification settings - Fork 54.3k
Open
Labels
staleMarked as stale due to inactivityMarked as stale due to inactivity
Description
Background
PR #25103 added multilingual abort trigger support by expanding the hardcoded ABORT_TRIGGERS Set with ES/FR/ZH/HI/AR/JP/DE/PT/RU keywords.
While this is a great step forward, I think the underlying approach has a scalability problem.
Problem
The current design hardcodes stop keywords into ABORT_TRIGGERS:
ABORT_TRIGGERS = new Set([
"stop", "abort", "please stop",
"停止", "やめて", "стоп", "arrête", ...
])This approach doesn't scale well:
- There are hundreds of languages — any language not in the list simply can't trigger an abort
- Each missing language requires a new PR (e.g. Korean is missing from Auto-reply: normalize stop matching and add multilingual triggers #25103)
- The Set will grow indefinitely with no clear stopping point
- Users with niche languages or custom workflows have no recourse
Proposed Solution
Expose a config option to let users define additional abort triggers:
{
"autoReply": {
"abort": {
"extraTriggers": [
"그만",
"멈춰",
"중단해",
"custom-stop-phrase"
]
}
}
}This way:
- Core multilingual coverage can still exist in the hardcoded Set as a baseline
- Users can extend for their own language or workflow without waiting for a PR
- The codebase stops growing indefinitely
Notes
- The normalization pipeline (
normalizeAbortTriggerText) already handles trim/lowercase/punctuation stripping, so extra triggers would slot in cleanly - This doesn't replace the existing hardcoded set — it augments it
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
staleMarked as stale due to inactivityMarked as stale due to inactivity