Skip to content

SecretsProvider: env, keyring, 1Password providers (building on #16663) #17311

@akoscz

Description

@akoscz

Context

PR #16663 by @amor71 delivers GCP, AWS, Azure, and Vault secret providers with CLI tooling, per-agent IAM isolation, stale-while-revalidate caching, migration scripts, and 130+ tests.

Our PR #11539 had a SecretsProvider interface and implementations for env vars and OS keyring. We closed it and are building on top of their work.

Plan

  1. Port env provider — resolves secrets from environment variables (with optional prefix, hyphen-to-underscore mapping)
  2. Port keyring provider — OS-native credential storage (macOS security CLI, Linux secret-tool/libsecret)
  3. Add 1Password provider — uses op CLI (op read op://vault/item/field), supports service account tokens for CI
  4. Register all three in buildSecretProviders()
  5. 🔄 Review + fix cycle — in progress
  6. Docs

Division of Labor

Who Scope
@amor71 GCP, AWS, Azure, Vault (done in #16663)
@akoscz env, keyring (macOS + Linux), 1Password

Depends On

References

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions