Skip to content

Commit fcc74d9

Browse files
fix(diagnostics): track model stream progress
1 parent 3ccd02d commit fcc74d9

1 file changed

Lines changed: 8 additions & 13 deletions

File tree

src/logging/diagnostic-run-activity.ts

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,11 @@ type DiagnosticModelStartedActivityEvent = Pick<
3131
"runId" | "sessionId" | "sessionKey" | "provider" | "model"
3232
>;
3333

34+
type DiagnosticRunProgressActivityEvent = Pick<
35+
Extract<DiagnosticEventPayload, { type: "run.progress" }>,
36+
"runId" | "sessionId" | "sessionKey" | "reason"
37+
>;
38+
3439
export type DiagnosticSessionActivitySnapshot = {
3540
activeWorkKind?: DiagnosticSessionActiveWorkKind;
3641
hasActiveEmbeddedRun?: boolean;
@@ -220,16 +225,11 @@ function recordModelEnded(
220225
touchSessionActivity(activity, "model_call:ended");
221226
}
222227

223-
function recordRunProgress(event: Extract<DiagnosticEventPayload, { type: "run.progress" }>): void {
228+
function recordRunProgress(event: DiagnosticRunProgressActivityEvent): void {
224229
markDiagnosticRunProgress(event);
225230
}
226231

227-
export function markDiagnosticRunProgress(params: {
228-
sessionId?: string;
229-
sessionKey?: string;
230-
runId?: string;
231-
reason: string;
232-
}): void {
232+
export function markDiagnosticRunProgress(params: DiagnosticRunProgressActivityEvent): void {
233233
const activity = resolveSessionActivity({ ...params, create: true });
234234
if (!activity) {
235235
return;
@@ -321,12 +321,7 @@ export function getDiagnosticSessionActivitySnapshot(
321321
};
322322
}
323323

324-
export function markDiagnosticRunProgressForTest(params: {
325-
sessionId?: string;
326-
sessionKey?: string;
327-
runId?: string;
328-
reason: string;
329-
}): void {
324+
export function markDiagnosticRunProgressForTest(params: DiagnosticRunProgressActivityEvent): void {
330325
markDiagnosticRunProgress(params);
331326
}
332327

0 commit comments

Comments
 (0)