fix(feishu): break loop on final-attempt fulfilled rate-limit body

marshallm-create · marshallm-create · commit fc9380ea1908 · 2026-06-08T22:00:16.000+08:00
ClawSweeper review on dc8d3be (P1, comment-shared.ts:166) caught a real bug: when the final retry attempt also fulfilled with a rate-limit body (e.g. { code: 11232, ... }), the guard `attempt < FEISHU_SEND_MAX_RETRIES` was false so control fell through to `return result` — bypassing the synthetic-error exhaustion path and handing the rate-limit body to the caller as if it were a successful response. The fulfilled-exhaustion test missed this because Vitest's local fs module cache served the pre-fix shape; running with a fresh cache reproduces the failure. Split the fulfilled-rate-limit branch so the body is always captured, then continue on a non-final attempt or break on the final attempt. Breaking falls through to the synthetic AxiosError-shaped throw below, which is exactly what the existing exhaustion test asserts.
diff --git a/extensions/feishu/src/comment-shared.ts b/extensions/feishu/src/comment-shared.ts
@@ -159,9 +159,15 @@ export async function requestFeishuApi<T>(
       // Feishu SDK may fulfill with a rate-limit body (e.g. { code: 11232, ... })
       // instead of throwing. Classify before returning so retry covers both shapes.
       const fulfilledRateLimit = getFeishuSendRateLimitCodeFromResponse(result);
-      if (fulfilledRateLimit !== undefined && attempt < FEISHU_SEND_MAX_RETRIES) {
+      if (fulfilledRateLimit !== undefined) {
+        // Capture for the synthetic-error path below; on a non-final attempt
+        // continue retrying, on the final attempt fall through so the loop
+        // exits and the wrapped exhaustion error is thrown.
         lastFulfilledRateLimit = { response: result, code: fulfilledRateLimit };
-        continue;
+        if (attempt < FEISHU_SEND_MAX_RETRIES) {
+          continue;
+        }
+        break;
       }
       return result;
     } catch (error) {
