Skip to content

Commit fc3246d

Browse files
steipetesteipete
committed
refactor: add public channel contract test seams
1 parent 04bde8c commit fc3246d

9 files changed

Lines changed: 34 additions & 29 deletions

File tree

‎extensions/discord/runtime-api.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,5 @@ export * from "./src/resolve-channels.js";
1717
export * from "./src/resolve-users.js";
1818
export * from "./src/outbound-session-route.js";
1919
export * from "./src/send.js";
20+
21+
export const discordSessionBindingAdapterChannels = ["discord"] as const;

‎extensions/discord/test-api.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export { buildFinalizedDiscordDirectInboundContext } from "./src/monitor/inbound-context.test-helpers.js";

‎extensions/feishu/api.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,5 @@ export * from "./src/setup-core.js";
33
export * from "./src/setup-surface.js";
44
export * from "./src/thread-bindings.js";
55
export { __testing as feishuThreadBindingTesting } from "./src/thread-bindings.js";
6+
7+
export const feishuSessionBindingAdapterChannels = ["feishu"] as const;

‎extensions/matrix/api.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,5 @@ export {
66
resetMatrixThreadBindingsForTests,
77
} from "./src/matrix/thread-bindings.js";
88
export { matrixOnboardingAdapter as matrixSetupWizard } from "./src/onboarding.js";
9+
10+
export const matrixSessionBindingAdapterChannels = ["matrix"] as const;

‎extensions/slack/test-api.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
export type { ResolvedSlackAccount } from "./src/accounts.js";
2+
export type { SlackMessageEvent } from "./src/types.js";
3+
export { prepareSlackMessage } from "./src/monitor/message-handler/prepare.js";
4+
export { createInboundSlackTestContext } from "./src/monitor/message-handler/prepare.test-helpers.js";

‎extensions/telegram/runtime-api.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,3 +83,5 @@ export {
8383
setTelegramThreadBindingMaxAgeBySessionKey,
8484
} from "./src/thread-bindings.js";
8585
export { resolveTelegramToken } from "./src/token.js";
86+
87+
export const telegramSessionBindingAdapterChannels = ["telegram"] as const;

‎extensions/telegram/test-api.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export { buildTelegramMessageContextForTest } from "./src/bot-message-context.test-harness.js";

‎src/channels/plugins/contracts/inbound.contract.test.ts‎

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
import { beforeEach, describe, expect, it, vi } from "vitest";
2-
import { buildFinalizedDiscordDirectInboundContext } from "../../../../extensions/discord/src/monitor/inbound-context.test-helpers.js";
3-
import type { ResolvedSlackAccount } from "../../../../extensions/slack/src/accounts.js";
4-
import type { SlackMessageEvent } from "../../../../extensions/slack/src/types.js";
2+
import { buildFinalizedDiscordDirectInboundContext } from "../../../../extensions/discord/test-api.js";
3+
import {
4+
createInboundSlackTestContext,
5+
prepareSlackMessage,
6+
type ResolvedSlackAccount,
7+
type SlackMessageEvent,
8+
} from "../../../../extensions/slack/test-api.js";
9+
import { buildTelegramMessageContextForTest } from "../../../../extensions/telegram/test-api.js";
510
import { withTempHome } from "../../../../test/helpers/temp-home.js";
611
import type { MsgContext } from "../../../auto-reply/templating.js";
712
import type { OpenClawConfig } from "../../../config/config.js";
@@ -75,12 +80,6 @@ vi.mock("../../../../extensions/whatsapp/src/auto-reply/deliver-reply.js", () =>
7580
}));
7681

7782
const { finalizeInboundContext } = await import("../../../auto-reply/reply/inbound-context.js");
78-
const { prepareSlackMessage } =
79-
await import("../../../../extensions/slack/src/monitor/message-handler/prepare.js");
80-
const { createInboundSlackTestContext } =
81-
await import("../../../../extensions/slack/src/monitor/message-handler/prepare.test-helpers.js");
82-
const { buildTelegramMessageContextForTest } =
83-
await import("../../../../extensions/telegram/src/bot-message-context.test-harness.js");
8483

8584
function createSlackAccount(config: ResolvedSlackAccount["config"] = {}): ResolvedSlackAccount {
8685
return {

‎src/channels/plugins/contracts/registry.contract.test.ts‎

Lines changed: 12 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,19 @@
1-
import fs from "node:fs";
2-
import path from "node:path";
31
import { describe, expect, it } from "vitest";
2+
import { discordSessionBindingAdapterChannels } from "../../../../extensions/discord/runtime-api.js";
3+
import { feishuSessionBindingAdapterChannels } from "../../../../extensions/feishu/api.js";
4+
import { matrixSessionBindingAdapterChannels } from "../../../../extensions/matrix/api.js";
5+
import { telegramSessionBindingAdapterChannels } from "../../../../extensions/telegram/runtime-api.js";
46
import { sessionBindingContractChannelIds } from "./manifest.js";
57

6-
const sessionBindingAdapterFiles = [
7-
"../../../../extensions/discord/src/monitor/thread-bindings.manager.ts",
8-
"../../../../extensions/feishu/src/thread-bindings.ts",
9-
"../../../../extensions/matrix/src/matrix/thread-bindings.ts",
10-
"../../../../extensions/telegram/src/thread-bindings.ts",
11-
] as const;
12-
138
function discoverSessionBindingChannels() {
14-
const channels = new Set<string>();
15-
for (const relativePath of sessionBindingAdapterFiles) {
16-
const filePath = path.resolve(import.meta.dirname, relativePath);
17-
const source = fs.readFileSync(filePath, "utf8");
18-
for (const match of source.matchAll(
19-
/registerSessionBindingAdapter\(\{[\s\S]*?channel:\s*"([^"]+)"/g,
20-
)) {
21-
channels.add(match[1]);
22-
}
23-
}
24-
return [...channels].toSorted();
9+
return [
10+
...new Set([
11+
...discordSessionBindingAdapterChannels,
12+
...feishuSessionBindingAdapterChannels,
13+
...matrixSessionBindingAdapterChannels,
14+
...telegramSessionBindingAdapterChannels,
15+
]),
16+
].toSorted();
2517
}
2618

2719
describe("channel contract registry", () => {

0 commit comments

Comments
 (0)