test(extensions): type mocked calls explicitly

Kaspre · Kaspre · commit fa93db7d8793 · 2026-05-11T04:48:34.000-04:00
diff --git a/extensions/msteams/src/monitor-handler.feedback-authz.test.ts b/extensions/msteams/src/monitor-handler.feedback-authz.test.ts
@@ -197,7 +197,7 @@ describe("msteams feedback invoke authz", () => {
           "utf-8",
         );
         const event = JSON.parse(transcript.trim()) as Record<string, unknown>;
-        expect(Object.keys(event).sort()).toEqual([
+        expect(Object.keys(event).toSorted()).toEqual([
           "agentId",
           "comment",
           "conversationId",
@@ -256,7 +256,7 @@ describe("msteams feedback invoke authz", () => {
           "utf-8",
         );
         const event = JSON.parse(transcript.trim()) as Record<string, unknown>;
-        expect(Object.keys(event).sort()).toEqual([
+        expect(Object.keys(event).toSorted()).toEqual([
           "agentId",
           "comment",
           "conversationId",
diff --git a/extensions/openrouter/image-generation-provider.test.ts b/extensions/openrouter/image-generation-provider.test.ts
@@ -114,10 +114,11 @@ describe("openrouter image generation provider", () => {
           providers: {
             openrouter: {
               baseUrl: "https://custom.openrouter.test/api/v1",
+              models: [],
             },
           },
         },
-      } as never,
+      },
     });
 
     expect(resolveApiKeyForProviderMock).toHaveBeenCalledOnce();
@@ -219,7 +220,7 @@ describe("openrouter image generation provider", () => {
       model: "google/gemini-3.1-flash-image-preview",
       prompt: "turn this into watercolor",
       inputImages: [{ buffer: Buffer.from("source-image"), mimeType: "image/png" }],
-      cfg: {} as never,
+      cfg: {},
     });
 
     const body = requireOpenRouterPostBody();
diff --git a/extensions/slack/src/message-tools.test.ts b/extensions/slack/src/message-tools.test.ts
@@ -34,7 +34,7 @@ describe("Slack message tools", () => {
       },
     });
 
-    expect(Object.keys(discovery).sort()).toEqual(["actions", "capabilities", "schema"]);
+    expect(Object.keys(discovery).toSorted()).toEqual(["actions", "capabilities", "schema"]);
     expect(discovery.actions).toEqual([
       "send",
       "react",
diff --git a/extensions/zalouser/src/zca-client.test.ts b/extensions/zalouser/src/zca-client.test.ts
@@ -3,21 +3,23 @@ import { describe, expect, it, vi } from "vitest";
 describe("zca-client runtime loading", () => {
   it("does not import zca-js until a session is created", async () => {
     vi.clearAllMocks();
+    let constructedOptions: { logging?: boolean; selfListen?: boolean } | undefined;
+    function MockZalo(options?: { logging?: boolean; selfListen?: boolean }) {
+      constructedOptions = options;
+    }
     const runtimeFactory = vi.fn(() => ({
-      Zalo: class MockZalo {
-        constructor(public readonly options?: { logging?: boolean; selfListen?: boolean }) {}
-      },
+      Zalo: MockZalo,
     }));
 
     vi.doMock("zca-js", runtimeFactory);
 
     const zcaClient = await import("./zca-client.js");
     expect(runtimeFactory).not.toHaveBeenCalled();
 
-    const client = await zcaClient.createZalo({ logging: false, selfListen: true });
+    await zcaClient.createZalo({ logging: false, selfListen: true });
 
     expect(runtimeFactory).toHaveBeenCalledTimes(1);
-    expect((client as { options?: { logging?: boolean; selfListen?: boolean } }).options).toEqual({
+    expect(constructedOptions).toEqual({
       logging: false,
       selfListen: true,
     });
