fix(discord): preserve disabled link buttons

100menotu001 · 100menotu001 · commit fa44df3025e2 · 2026-05-19T11:45:36.000-04:00
diff --git a/extensions/discord/src/components.builders.ts b/extensions/discord/src/components.builders.ts
@@ -60,6 +60,7 @@ function createButtonComponent(params: {
     class DynamicLinkButton extends LinkButton {
       label = params.spec.label;
       url = linkUrl;
+      override disabled = params.spec.disabled ?? false;
     }
     return { component: new DynamicLinkButton() };
   }
diff --git a/extensions/discord/src/components.test.ts b/extensions/discord/src/components.test.ts
@@ -1,4 +1,4 @@
-import { MessageFlags } from "discord-api-types/v10";
+import { ButtonStyle, MessageFlags } from "discord-api-types/v10";
 import { beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
 
 let clearDiscordComponentEntries: typeof import("./components-registry.js").clearDiscordComponentEntries;
@@ -60,6 +60,41 @@ describe("discord components", () => {
     expect(result.modals[0]?.allowedUsers).toEqual(["discord:user-1"]);
   });
 
+  it("serializes disabled link buttons", () => {
+    const spec = readDiscordComponentSpec({
+      blocks: [
+        {
+          type: "actions",
+          buttons: [
+            {
+              label: "Open docs",
+              style: "link",
+              url: "https://example.com/docs",
+              disabled: true,
+            },
+          ],
+        },
+      ],
+    });
+    if (!spec) {
+      throw new Error("Expected component spec to be parsed");
+    }
+
+    const result = buildDiscordComponentMessage({ spec });
+    const serialized = result.components[0]?.serialize() as
+      | { components?: Array<{ components?: Array<Record<string, unknown>> }> }
+      | undefined;
+    const button = serialized?.components?.[0]?.components?.[0];
+
+    expect(button).toMatchObject({
+      label: "Open docs",
+      style: ButtonStyle.Link,
+      url: "https://example.com/docs",
+      disabled: true,
+    });
+    expect(result.entries).toHaveLength(0);
+  });
+
   it("requires options for modal select fields", () => {
     expect(() =>
       readDiscordComponentSpec({
diff --git a/extensions/discord/src/outbound-adapter.test.ts b/extensions/discord/src/outbound-adapter.test.ts
@@ -589,7 +589,10 @@ describe("discordOutbound", () => {
         blocks: [
           {
             type: "buttons",
-            buttons: [{ label: "Already handled", value: "done", disabled: true }],
+            buttons: [
+              { label: "Already handled", value: "done", disabled: true },
+              { label: "Open docs", url: "https://example.com/docs", disabled: true },
+            ],
           },
         ],
       },
@@ -611,16 +614,22 @@ describe("discordOutbound", () => {
     const discordData = payload.channelData?.discord as
       | { presentationComponents?: { blocks?: Array<{ type?: string; buttons?: unknown[] }> } }
       | undefined;
-    const button = discordData?.presentationComponents?.blocks?.find(
+    const buttons = discordData?.presentationComponents?.blocks?.find(
       (block) => block.type === "actions",
-    )?.buttons?.[0];
+    )?.buttons;
 
-    expect(button).toEqual({
+    expect(buttons?.[0]).toEqual({
       label: "Already handled",
       style: "secondary",
       callbackData: "done",
       disabled: true,
     });
+    expect(buttons?.[1]).toEqual({
+      label: "Open docs",
+      style: "link",
+      url: "https://example.com/docs",
+      disabled: true,
+    });
   });
 
   it("keeps replyToId on every internal component media send when replyToMode is all", async () => {
diff --git a/extensions/discord/src/shared-interactive.test.ts b/extensions/discord/src/shared-interactive.test.ts
@@ -157,7 +157,10 @@ describe("buildDiscordInteractiveComponents", () => {
         blocks: [
           {
             type: "buttons",
-            buttons: [{ label: "Already handled", value: "done", disabled: true }],
+            buttons: [
+              { label: "Already handled", value: "done", disabled: true },
+              { label: "Open docs", url: "https://example.com/docs", disabled: true },
+            ],
           },
         ],
       }),
@@ -172,6 +175,12 @@ describe("buildDiscordInteractiveComponents", () => {
               callbackData: "done",
               disabled: true,
             },
+            {
+              label: "Open docs",
+              style: "link",
+              url: "https://example.com/docs",
+              disabled: true,
+            },
           ],
         },
       ],

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,7 @@ function createButtonComponent(params: {`
`60`	`60`	`class DynamicLinkButton extends LinkButton {`
`61`	`61`	`label = params.spec.label;`
`62`	`62`	`url = linkUrl;`
	`63`	`+ override disabled = params.spec.disabled ?? false;`
`63`	`64`	`}`
`64`	`65`	`return { component: new DynamicLinkButton() };`
`65`	`66`	`}`