fix(update): reject blank timeout values

Gio Della-Libera · Gio Della-Libera · commit f5e6e06f8ee2 · 2026-05-17T18:31:43.000-07:00
diff --git a/src/cli/update-cli/shared.command-runner.test.ts b/src/cli/update-cli/shared.command-runner.test.ts
@@ -59,10 +59,11 @@ describe("createGlobalCommandRunner", () => {
       expect(parseTimeoutMsOrExit("10abc")).toBeNull();
       expect(parseTimeoutMsOrExit("0")).toBeNull();
       expect(parseTimeoutMsOrExit("-1")).toBeNull();
+      expect(parseTimeoutMsOrExit("   ")).toBeNull();
 
-      expect(error).toHaveBeenCalledTimes(4);
+      expect(error).toHaveBeenCalledTimes(5);
       expect(error).toHaveBeenCalledWith("--timeout must be a positive integer (seconds)");
-      expect(exit).toHaveBeenCalledTimes(4);
+      expect(exit).toHaveBeenCalledTimes(5);
       expect(exit).toHaveBeenCalledWith(1);
     } finally {
       error.mockRestore();
diff --git a/src/cli/update-cli/shared.ts b/src/cli/update-cli/shared.ts
@@ -54,10 +54,10 @@ export type UpdateWizardOptions = {
 const INVALID_TIMEOUT_ERROR = "--timeout must be a positive integer (seconds)";
 
 export function parseTimeoutMsOrExit(timeout?: string): number | undefined | null {
-  const trimmed = timeout?.trim();
-  if (!trimmed) {
+  if (timeout === undefined) {
     return undefined;
   }
+  const trimmed = timeout.trim();
   const seconds = Number(trimmed);
   if (!/^\d+$/u.test(trimmed) || !Number.isSafeInteger(seconds) || seconds <= 0) {
     defaultRuntime.error(INVALID_TIMEOUT_ERROR);
