Address Xiaomi PR review feedback

HiddenPuppy · HiddenPuppy · commit efe792204ed0 · 2026-04-03T21:27:01.000+08:00
diff --git a/extensions/xiaomi/index.test.ts b/extensions/xiaomi/index.test.ts
@@ -59,49 +59,52 @@ function runWrappedXiaomiStream(params: {
 }
 
 describe("xiaomi provider plugin", () => {
-  it("normalizes reasoning-only final assistant messages into text for MiMo reasoning models", async () => {
-    const stream = runWrappedXiaomiStream({
-      modelId: "mimo-v2-pro",
-      events: [
+  it.each(["mimo-v2-pro", "mimo-v2-omni"])(
+    "normalizes reasoning-only final assistant messages into text for %s",
+    async (modelId) => {
+      const stream = runWrappedXiaomiStream({
+        modelId,
+        events: [
+          {
+            type: "done",
+            reason: "stop",
+            message: {
+              role: "assistant",
+              content: [{ type: "thinking", thinking: "MiMo final answer" }],
+              stopReason: "stop",
+            },
+          },
+        ],
+        resultMessage: {
+          role: "assistant",
+          content: [{ type: "thinking", thinking: "MiMo final answer" }],
+          stopReason: "stop",
+        },
+      });
+
+      const events: unknown[] = [];
+      for await (const event of stream) {
+        events.push(event);
+      }
+
+      await expect(stream.result()).resolves.toEqual({
+        role: "assistant",
+        content: [{ type: "text", text: "MiMo final answer" }],
+        stopReason: "stop",
+      });
+      expect(events).toEqual([
         {
           type: "done",
           reason: "stop",
           message: {
             role: "assistant",
-            content: [{ type: "thinking", thinking: "MiMo final answer" }],
+            content: [{ type: "text", text: "MiMo final answer" }],
             stopReason: "stop",
           },
         },
-      ],
-      resultMessage: {
-        role: "assistant",
-        content: [{ type: "thinking", thinking: "MiMo final answer" }],
-        stopReason: "stop",
-      },
-    });
-
-    const events: unknown[] = [];
-    for await (const event of stream) {
-      events.push(event);
-    }
-
-    await expect(stream.result()).resolves.toEqual({
-      role: "assistant",
-      content: [{ type: "text", text: "MiMo final answer" }],
-      stopReason: "stop",
-    });
-    expect(events).toEqual([
-      {
-        type: "done",
-        reason: "stop",
-        message: {
-          role: "assistant",
-          content: [{ type: "text", text: "MiMo final answer" }],
-          stopReason: "stop",
-        },
-      },
-    ]);
-  });
+      ]);
+    },
+  );
 
   it("leaves non-target Xiaomi models unchanged", async () => {
     const stream = runWrappedXiaomiStream({
diff --git a/extensions/xiaomi/stream.ts b/extensions/xiaomi/stream.ts
@@ -61,7 +61,6 @@ function rewriteXiaomiReasoningContentAsTextInMessage(message: unknown): void {
       typedBlock.text.trim()
     ) {
       hasRenderableText = true;
-      break;
     }
     if (typedBlock.type === "toolCall") {
       hasToolCalls = true;

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,6 @@ function rewriteXiaomiReasoningContentAsTextInMessage(message: unknown): void {`
`61`	`61`	`typedBlock.text.trim()`
`62`	`62`	`) {`
`63`	`63`	`hasRenderableText = true;`
`64`		`- break;`
`65`	`64`	`}`
`66`	`65`	`if (typedBlock.type === "toolCall") {`
`67`	`66`	`hasToolCalls = true;`