test(matrix): make voice preflight QA mention deterministic

steipete · steipete · commit eeb1ce96090c · 2026-06-04T14:12:23.000-04:00
diff --git a/extensions/qa-matrix/src/runners/contract/scenario-catalog.ts b/extensions/qa-matrix/src/runners/contract/scenario-catalog.ts
@@ -503,6 +503,7 @@ export const MATRIX_QA_SCENARIOS: MatrixQaScenarioDefinition[] = [
       audio: {
         enabled: true,
       },
+      groupMentionPatterns: ["\\S"],
     },
     providerMode: "live-frontier",
     timeoutMs: 180_000,
diff --git a/extensions/qa-matrix/src/runners/contract/scenarios.test.ts b/extensions/qa-matrix/src/runners/contract/scenarios.test.ts
@@ -4615,6 +4615,7 @@ describe("matrix live qa scenarios", () => {
 
     const scenario = requireMatrixQaScenario("matrix-voice-preflight-mention");
     expect(scenario.configOverrides?.audio?.enabled).toBe(true);
+    expect(scenario.configOverrides?.groupMentionPatterns).toEqual(["\\S"]);
 
     const result = await runMatrixQaScenario(scenario, {
       baseUrl: "http://127.0.0.1:28008/",
diff --git a/extensions/qa-matrix/src/substrate/config.test.ts b/extensions/qa-matrix/src/substrate/config.test.ts
@@ -109,6 +109,7 @@ describe("matrix qa config", () => {
         allowBots: "mentions",
         configuredBotRoles: ["observer"],
         groupAllowFrom: ["@driver:matrix-qa.test", "@observer:matrix-qa.test"],
+        groupMentionPatterns: ["\\S"],
         groupsByKey: {
           secondary: {
             allowBots: false,
@@ -154,6 +155,7 @@ describe("matrix qa config", () => {
       echoTranscript: false,
       enabled: true,
     });
+    expect(next.messages?.groupChat?.mentionPatterns).toEqual(["\\S"]);
     const observer = next.channels?.matrix?.accounts?.["qa-observer-bot-source"];
     expect(observer?.accessToken).toBe("observer-token");
     expect(observer?.enabled).toBe(false);
@@ -234,6 +236,7 @@ describe("matrix qa config", () => {
         dm: {
           sessionScope: "per-room",
         },
+        groupMentionPatterns: ["\\S"],
         groupPolicy: "open",
         streaming: true,
       },
@@ -262,6 +265,7 @@ describe("matrix qa config", () => {
       execApprovals: undefined,
       configuredBotRoles: [],
       groupAllowFrom: ["@driver:matrix-qa.test"],
+      groupMentionPatterns: ["\\S"],
       groupPolicy: "open",
       groupsByKey: {
         main: {
@@ -284,6 +288,7 @@ describe("matrix qa config", () => {
     });
     expect(summarizeMatrixQaConfigSnapshot(snapshot)).toContain("allowBots=<default>");
     expect(summarizeMatrixQaConfigSnapshot(snapshot)).toContain("configuredBotRoles=<none>");
+    expect(summarizeMatrixQaConfigSnapshot(snapshot)).toContain("groupMentionPatterns=\\S");
     expect(summarizeMatrixQaConfigSnapshot(snapshot)).toContain("autoJoin=allowlist");
     expect(summarizeMatrixQaConfigSnapshot(snapshot)).toContain("streaming=partial");
     expect(summarizeMatrixQaConfigSnapshot(snapshot)).toContain(
diff --git a/extensions/qa-matrix/src/substrate/config.ts b/extensions/qa-matrix/src/substrate/config.ts
@@ -94,6 +94,7 @@ export type MatrixQaConfigOverrides = {
   execApprovals?: MatrixQaExecApprovalsConfigOverrides;
   groupAllowFrom?: string[];
   groupAllowRoles?: MatrixQaActorRole[];
+  groupMentionPatterns?: string[];
   groupPolicy?: MatrixQaGroupPolicy;
   configuredBotRoles?: MatrixQaActorRole[];
   groupsByKey?: Record<string, MatrixQaGroupConfigOverrides>;
@@ -128,6 +129,7 @@ export type MatrixQaConfigSnapshot = {
   execApprovals?: MatrixQaExecApprovalsConfigOverrides;
   configuredBotRoles: MatrixQaActorRole[];
   groupAllowFrom: string[];
+  groupMentionPatterns: string[];
   groupPolicy: MatrixQaGroupPolicy;
   groupsByKey: Record<string, MatrixQaGroupSnapshot>;
   replyToMode: MatrixQaReplyToMode;
@@ -511,6 +513,7 @@ export function buildMatrixQaConfigSnapshot(params: {
     execApprovals: params.overrides?.execApprovals,
     configuredBotRoles: [...(params.overrides?.configuredBotRoles ?? [])],
     groupAllowFrom: resolveMatrixQaGroupAllowFrom(params),
+    groupMentionPatterns: normalizeMatrixQaAllowlist(params.overrides?.groupMentionPatterns),
     groupPolicy: params.overrides?.groupPolicy ?? "allowlist",
     groupsByKey: resolveMatrixQaGroupSnapshots({
       overrides: params.overrides,
@@ -543,6 +546,7 @@ export function summarizeMatrixQaConfigSnapshot(snapshot: MatrixQaConfigSnapshot
     `dm.policy=${snapshot.dm.policy}`,
     `dm.sessionScope=${snapshot.dm.sessionScope}`,
     `dm.threadReplies=${snapshot.dm.threadReplies}`,
+    `groupMentionPatterns=${snapshot.groupMentionPatterns.length > 0 ? snapshot.groupMentionPatterns.join("|") : "<default>"}`,
     `streaming=${snapshot.streaming}`,
     `streaming.preview.toolProgress=${formatMatrixQaBoolean(snapshot.streamingPreviewToolProgress)}`,
     `textChunkLimit=${snapshot.textChunkLimit ?? "<default>"}`,
@@ -674,6 +678,9 @@ export function buildMatrixQaConfig(
       ...baseCfg.messages,
       groupChat: {
         ...baseCfg.messages?.groupChat,
+        ...(snapshot.groupMentionPatterns.length > 0
+          ? { mentionPatterns: snapshot.groupMentionPatterns }
+          : {}),
         visibleReplies: "automatic",
       },
     },
