fix(discord): default non-finite identify concurrency

steipete · steipete · commit e7fb8cabb681 · 2026-05-28T23:40:43.000-04:00
diff --git a/extensions/discord/src/internal/gateway-identify-limiter.ts b/extensions/discord/src/internal/gateway-identify-limiter.ts
@@ -1,10 +1,17 @@
+import { parseFiniteNumber } from "openclaw/plugin-sdk/number-runtime";
+
 const IDENTIFY_WINDOW_MS = 5_000;
 
+function normalizeMaxConcurrency(value: number | undefined): number {
+  const parsed = parseFiniteNumber(value);
+  return parsed === undefined ? 1 : Math.max(1, Math.floor(parsed));
+}
+
 class GatewayIdentifyLimiter {
   private nextAllowedAtByKey = new Map<number, number>();
 
   async wait(params: { shardId?: number; maxConcurrency?: number }): Promise<void> {
-    const maxConcurrency = Math.max(1, Math.floor(params.maxConcurrency ?? 1));
+    const maxConcurrency = normalizeMaxConcurrency(params.maxConcurrency);
     const rateKey = (params.shardId ?? 0) % maxConcurrency;
     const now = Date.now();
     const nextAllowedAt = this.nextAllowedAtByKey.get(rateKey) ?? now;
diff --git a/extensions/discord/src/internal/gateway.test.ts b/extensions/discord/src/internal/gateway.test.ts
@@ -234,6 +234,29 @@ describe("GatewayPlugin", () => {
     );
   });
 
+  it("uses the safe single identify bucket for non-finite max concurrency", async () => {
+    vi.useFakeTimers();
+    vi.setSystemTime(0);
+
+    await sharedGatewayIdentifyLimiter.wait({
+      shardId: 0,
+      maxConcurrency: Number.POSITIVE_INFINITY,
+    });
+    let secondResolved = false;
+    const second = sharedGatewayIdentifyLimiter
+      .wait({ shardId: 1, maxConcurrency: Number.POSITIVE_INFINITY })
+      .then(() => {
+        secondResolved = true;
+      });
+
+    await vi.advanceTimersByTimeAsync(4_999);
+    expect(secondResolved).toBe(false);
+
+    await vi.advanceTimersByTimeAsync(1);
+    await second;
+    expect(secondResolved).toBe(true);
+  });
+
   it("preserves MESSAGE_CREATE author payloads for inbound dispatch", async () => {
     const gateway = new GatewayPlugin({ autoInteractions: false });
     const dispatchGatewayEvent = vi.fn(async (eventValue: string, dataValue: unknown) => {});
