fix(ci): GitHub App active-PR-limit exemption regression (#75311)

clawsweeper[bot] · openclaw-clownfish[bot] · web-flow · commit e47a7448e90f · 2026-04-30T17:10:20.000-07:00
Co-authored-by: openclaw-clawsweeper[bot] &lt;280122609+openclaw-clawsweeper[bot]@users.noreply.github.com&gt;
diff --git a/scripts/github/barnacle-auto-response.mjs b/scripts/github/barnacle-auto-response.mjs
@@ -808,12 +808,12 @@ async function removeLabels(github, context, issueNumber, labels, labelSet) {
         issue_number: issueNumber,
         name: label,
       });
-      labelSet.delete(label);
     } catch (error) {
       if (error?.status !== 404) {
         throw error;
       }
     }
+    labelSet.delete(label);
   }
 }
 
diff --git a/test/scripts/barnacle-auto-response.test.ts b/test/scripts/barnacle-auto-response.test.ts
@@ -105,11 +105,16 @@ function barnacleIssueContext(
 
 function barnacleGithub(
   files: ReturnType<typeof file>[],
-  options: { maintainerLogins?: string[]; repositoryRoles?: Record<string, string> } = {},
+  options: {
+    maintainerLogins?: string[];
+    removeLabelNotFound?: string[];
+    repositoryRoles?: Record<string, string>;
+  } = {},
 ) {
   const maintainerLogins = new Set(
     (options.maintainerLogins ?? []).map((login) => login.toLowerCase()),
   );
+  const removeLabelNotFound = new Set(options.removeLabelNotFound ?? []);
   const repositoryRoles = Object.fromEntries(
     Object.entries(options.repositoryRoles ?? {}).map(([login, role]) => [
       login.toLowerCase(),
@@ -147,6 +152,11 @@ function barnacleGithub(
         },
         removeLabel: async (params: { issue_number: number; name: string }) => {
           calls.removeLabel.push(params);
+          if (removeLabelNotFound.has(params.name)) {
+            const error = new Error("not found") as Error & { status: number };
+            error.status = 404;
+            throw error;
+          }
         },
         update: async (params: { issue_number: number; state?: string }) => {
           calls.update.push(params);
@@ -516,6 +526,32 @@ describe("barnacle-auto-response", () => {
     expect(calls.update).toEqual([]);
   });
 
+  it("does not close GitHub App-authored PRs when stale PR-limit label removal returns 404", async () => {
+    const { calls, github } = barnacleGithub([file("README.md")], {
+      removeLabelNotFound: ["r: too-many-prs"],
+    });
+
+    await runBarnacleAutoResponse({
+      github,
+      context: barnacleContext(
+        {
+          user: {
+            login: "renovate[bot]",
+            type: "Bot",
+          },
+        },
+        ["r: too-many-prs"],
+      ),
+      core: {
+        info: () => undefined,
+      },
+    });
+
+    expect(calls.removeLabel).toContainEqual(expect.objectContaining({ name: "r: too-many-prs" }));
+    expect(calls.createComment).toEqual([]);
+    expect(calls.update).toEqual([]);
+  });
+
   it("still adds candidate labels to broad contributor PRs", async () => {
     const { calls, github } = barnacleGithub([
       file("ui/src/app.ts"),

Original file line number	Diff line number	Diff line change
`@@ -808,12 +808,12 @@ async function removeLabels(github, context, issueNumber, labels, labelSet) {`
`808`	`808`	`issue_number: issueNumber,`
`809`	`809`	`name: label,`
`810`	`810`	`});`
`811`		`- labelSet.delete(label);`
`812`	`811`	`} catch (error) {`
`813`	`812`	`if (error?.status !== 404) {`
`814`	`813`	`throw error;`
`815`	`814`	`}`
`816`	`815`	`}`
	`816`	`+ labelSet.delete(label);`
`817`	`817`	`}`
`818`	`818`	`}`
`819`	`819`