test(doctor): cover partial legacy migration writes

steipete · steipete · commit e4490be3f266 · 2026-05-04T00:28:21.000+01:00
diff --git a/src/commands/doctor/shared/legacy-config-migrate.test.ts b/src/commands/doctor/shared/legacy-config-migrate.test.ts
@@ -1,5 +1,6 @@
 import { describe, expect, it } from "vitest";
 import type { OpenClawConfig } from "../../../config/types.js";
+import { migrateLegacyConfig } from "./legacy-config-migrate.js";
 import { LEGACY_CONFIG_MIGRATIONS } from "./legacy-config-migrations.js";
 
 function migrateLegacyConfigForTest(raw: unknown): {
@@ -210,6 +211,38 @@ describe("legacy migrate mention routing", () => {
 });
 
 describe("legacy migrate sandbox scope aliases", () => {
+  it("returns migrated config when unrelated plugin validation issues remain (#76798)", () => {
+    const res = migrateLegacyConfig({
+      agents: {
+        defaults: {
+          model: { primary: "openai/gpt-5.5" },
+          llm: { idleTimeoutSeconds: 120 },
+        },
+      },
+      plugins: {
+        entries: {
+          brave: {
+            enabled: true,
+            config: { webSearch: { mode: "definitely-invalid" } },
+          },
+        },
+      },
+      tools: { web: { search: { provider: "brave" } } },
+    });
+
+    expect(res.partiallyValid).toBe(true);
+    expect(res.changes).toContain(
+      "Removed agents.defaults.llm; model idle timeout now follows models.providers.<id>.timeoutSeconds.",
+    );
+    expect(res.changes).toContain(
+      "Migration applied; other validation issues remain — run doctor to review.",
+    );
+    expect(res.config?.agents?.defaults).toEqual({
+      model: { primary: "openai/gpt-5.5" },
+    });
+    expect(res.config?.tools?.web?.search?.provider).toBe("brave");
+  });
+
   it("removes legacy agents.defaults.llm timeout config", () => {
     const res = migrateLegacyConfigForTest({
       agents: {
diff --git a/src/config/io.write-config.test.ts b/src/config/io.write-config.test.ts
@@ -1220,49 +1220,66 @@ describe("config io write", () => {
   });
 
   it("skipPluginValidation bypasses plugin schema rejection on writeConfigFile (#76800)", async () => {
-    mockLoadPluginManifestRegistry.mockReturnValue({
-      diagnostics: [],
-      plugins: [
-        {
-          id: "strict-plugin",
-          origin: "bundled",
-          channels: [],
-          providers: [],
-          cliBackends: [],
-          skills: [],
-          hooks: [],
-          rootDir: "/tmp/openclaw-test-strict-plugin",
-          source: "/tmp/openclaw-test-strict-plugin/index.ts",
-          manifestPath: "/tmp/openclaw-test-strict-plugin/openclaw.plugin.json",
-          configSchema: {
-            type: "object",
-            properties: { token: { type: "string" } },
-            required: ["token"],
-            additionalProperties: false,
-          },
-        },
-      ],
-    } satisfies PluginManifestRegistry);
-
     await withSuiteHome(async (home) => {
       const configPath = path.join(home, ".openclaw", "openclaw.json");
+      const previousConfigPath = process.env.OPENCLAW_CONFIG_PATH;
+      process.env.OPENCLAW_CONFIG_PATH = configPath;
       await fs.mkdir(path.dirname(configPath), { recursive: true });
       await fs.writeFile(configPath, "{}\n", "utf-8");
-      // Plugin is enabled but missing required "token" — validation fails without skip
-      const cfg: OpenClawConfig = {
-        agents: { list: [{ id: "main", default: true }] },
-        plugins: { entries: { "strict-plugin": { enabled: true } } },
-      };
+      mockLoadPluginManifestRegistry.mockReturnValue({
+        diagnostics: [],
+        plugins: [
+          {
+            id: "strict-plugin",
+            origin: "bundled",
+            channels: [],
+            providers: [],
+            cliBackends: [],
+            skills: [],
+            hooks: [],
+            rootDir: "/tmp/openclaw-test-strict-plugin",
+            source: "/tmp/openclaw-test-strict-plugin/index.ts",
+            manifestPath: "/tmp/openclaw-test-strict-plugin/openclaw.plugin.json",
+            configSchema: {
+              type: "object",
+              properties: { token: { type: "string" } },
+              required: ["token"],
+              additionalProperties: false,
+            },
+          },
+        ],
+      } satisfies PluginManifestRegistry);
 
-      await expect(writeConfigFile(cfg, { skipPluginValidation: true })).resolves.not.toThrow();
+      try {
+        // Plugin is enabled but missing required "token" — validation fails without skip.
+        const cfg: OpenClawConfig = {
+          agents: { list: [{ id: "main", default: true }] },
+          plugins: { entries: { "strict-plugin": { enabled: true } } },
+        };
 
-      await expect(writeConfigFile(cfg, { skipPluginValidation: false })).rejects.toThrow();
-    });
+        await expect(writeConfigFile(cfg, { skipPluginValidation: true })).resolves.not.toThrow();
+        await expect(fs.readFile(configPath, "utf-8")).resolves.toContain('"strict-plugin"');
 
-    mockLoadPluginManifestRegistry.mockReturnValue({
-      diagnostics: [],
-      plugins: [],
-    } satisfies PluginManifestRegistry);
+        await expect(writeConfigFile(cfg, { skipPluginValidation: false })).rejects.toThrow(
+          /Config validation failed/,
+        );
+        await expect(
+          writeConfigFile({ agents: { list: "not-array" } } as unknown as OpenClawConfig, {
+            skipPluginValidation: true,
+          }),
+        ).rejects.toThrow(/Config validation failed/);
+      } finally {
+        mockLoadPluginManifestRegistry.mockReturnValue({
+          diagnostics: [],
+          plugins: [],
+        } satisfies PluginManifestRegistry);
+        if (previousConfigPath === undefined) {
+          delete process.env.OPENCLAW_CONFIG_PATH;
+        } else {
+          process.env.OPENCLAW_CONFIG_PATH = previousConfigPath;
+        }
+      }
+    });
   });
 
   it("preserves authored tilde paths when runtime-shaped writes hand back absolute paths", async () => {
