test: tighten doctor update progress coverage

shakkernerd · shakkernerd · commit e3a6da0f5181 · 2026-06-12T17:58:28.000+01:00
diff --git a/src/commands/doctor-update.test.ts b/src/commands/doctor-update.test.ts
@@ -4,6 +4,7 @@ import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 import { maybeOfferUpdateBeforeDoctor } from "./doctor-update.js";
 
 const originalStdinIsTtyDescriptor = Object.getOwnPropertyDescriptor(process.stdin, "isTTY");
+const originalStdoutIsTtyDescriptor = Object.getOwnPropertyDescriptor(process.stdout, "isTTY");
 
 const mocks = vi.hoisted(() => ({
   createUpdateProgress: vi.fn(),
@@ -52,6 +53,10 @@ beforeEach(async () => {
     configurable: true,
     value: true,
   });
+  Object.defineProperty(process.stdout, "isTTY", {
+    configurable: true,
+    value: true,
+  });
 });
 
 afterEach(() => {
@@ -61,6 +66,11 @@ afterEach(() => {
   } else {
     delete (process.stdin as Partial<typeof process.stdin>).isTTY;
   }
+  if (originalStdoutIsTtyDescriptor) {
+    Object.defineProperty(process.stdout, "isTTY", originalStdoutIsTtyDescriptor);
+  } else {
+    delete (process.stdout as Partial<typeof process.stdout>).isTTY;
+  }
 });
 
 describe("maybeOfferUpdateBeforeDoctor", () => {
@@ -115,9 +125,42 @@ describe("maybeOfferUpdateBeforeDoctor", () => {
     await expect(runOffer({ root: "/repo/link", confirm })).rejects.toThrow("update exploded");
 
     expect(mocks.runGatewayUpdate).toHaveBeenCalledWith(expect.objectContaining({ progress }));
+    expect(mocks.createUpdateProgress).toHaveBeenCalledWith(true);
     expect(stop).toHaveBeenCalledTimes(1);
   });
 
+  it("disables update progress when stdout is not a TTY", async () => {
+    Object.defineProperty(process.stdout, "isTTY", {
+      configurable: true,
+      value: false,
+    });
+    vi.spyOn(fs, "realpath").mockImplementation(async (candidate) => String(candidate));
+    mocks.runCommandWithTimeout.mockResolvedValue({
+      stdout: "/repo/link\n",
+      stderr: "",
+      code: 0,
+      killed: false,
+      signal: null,
+      termination: "exit",
+      noOutputTimedOut: false,
+    });
+    mocks.runGatewayUpdate.mockResolvedValue({
+      status: "skipped",
+      mode: "git",
+      root: "/repo/link",
+      steps: [],
+      durationMs: 0,
+    });
+
+    const confirm = vi.fn().mockResolvedValue(true);
+    await expect(runOffer({ root: "/repo/link", confirm })).resolves.toEqual({
+      updated: true,
+      handled: false,
+    });
+
+    expect(mocks.createUpdateProgress).toHaveBeenCalledWith(false);
+  });
+
   it("keeps package-manager guidance when git reports a different checkout", async () => {
     const confirm = vi.fn();
     vi.spyOn(fs, "realpath").mockImplementation(async (candidate) => String(candidate));
diff --git a/src/commands/doctor-update.ts b/src/commands/doctor-update.ts
@@ -7,6 +7,7 @@ import { formatCliCommand } from "../cli/command-format.js";
 import { createUpdateProgress } from "../cli/update-cli/progress.js";
 import { isTruthyEnvValue } from "../infra/env.js";
 import { runGatewayUpdate } from "../infra/update-runner.js";
+import type { UpdateRunResult } from "../infra/update-runner.js";
 import { runCommandWithTimeout } from "../process/exec.js";
 import type { RuntimeEnv } from "../runtime.js";
 import type { DoctorOptions } from "./doctor-prompter.js";
@@ -66,7 +67,7 @@ export async function maybeOfferUpdateBeforeDoctor(params: {
     }
     note("Running update…", "Update");
     const { progress, stop } = createUpdateProgress(process.stdout.isTTY);
-    let result;
+    let result: UpdateRunResult;
     try {
       result = await runGatewayUpdate({
         cwd: params.root,
