fix(tui): force render final early returns

MonkeyLeeT · MonkeyLeeT · commit e1dcd27a01bb · 2026-05-27T09:30:51.000-07:00
diff --git a/src/tui/tui-event-handlers.test.ts b/src/tui/tui-event-handlers.test.ts
@@ -469,7 +469,7 @@ describe("tui-event-handlers: handleAgentEvent", () => {
   });
 
   it("keeps a local BTW result visible when its empty final chat event arrives", () => {
-    const { state, btw, loadHistory, noteLocalBtwRunId, handleBtwEvent, handleChatEvent } =
+    const { state, btw, loadHistory, noteLocalBtwRunId, tui, handleBtwEvent, handleChatEvent } =
       createHandlersHarness({
         state: { activeChatRunId: null },
       });
@@ -482,6 +482,7 @@ describe("tui-event-handlers: handleAgentEvent", () => {
       question: "what changed?",
       text: "nothing important",
     } satisfies BtwEvent);
+    tui.requestRender.mockClear();
 
     handleChatEvent({
       runId: "run-btw",
@@ -495,6 +496,7 @@ describe("tui-event-handlers: handleAgentEvent", () => {
       text: "nothing important",
       isError: undefined,
     });
+    expect(tui.requestRender).toHaveBeenCalledWith(true);
   });
 
   it("clears stale streaming for a local BTW empty final without hiding the result", () => {
@@ -701,6 +703,25 @@ describe("tui-event-handlers: handleAgentEvent", () => {
     expect(loadHistory).toHaveBeenCalledTimes(1);
   });
 
+  it("forces render when a command final only adds system text", () => {
+    const { state, chatLog, tui, handleChatEvent } = createHandlersHarness({
+      state: { activeChatRunId: "run-command" },
+    });
+
+    handleChatEvent({
+      runId: "run-command",
+      sessionKey: state.currentSessionKey,
+      state: "final",
+      message: {
+        command: true,
+        content: [{ type: "text", text: "/status done" }],
+      },
+    });
+
+    expect(chatLog.addSystem).toHaveBeenCalledWith("/status done");
+    expect(tui.requestRender).toHaveBeenCalledWith(true);
+  });
+
   it("binds optimistic pending messages to the first gateway run id and skips history reload", () => {
     const { state, loadHistory, isLocalRunId, handleChatEvent } = createHandlersHarness({
       state: { activeChatRunId: null, pendingOptimisticUserMessage: true },
@@ -1127,7 +1148,7 @@ describe("tui-event-handlers: handleAgentEvent", () => {
   });
 
   it("reloads history when a local run ends without a displayable final message", () => {
-    const { state, loadHistory, noteLocalRunId, handleChatEvent } = createHandlersHarness({
+    const { state, loadHistory, noteLocalRunId, tui, handleChatEvent } = createHandlersHarness({
       state: { activeChatRunId: "run-local-silent" },
     });
 
@@ -1140,6 +1161,7 @@ describe("tui-event-handlers: handleAgentEvent", () => {
     });
 
     expect(loadHistory).toHaveBeenCalledTimes(1);
+    expect(tui.requestRender).toHaveBeenCalledWith(true);
   });
 
   it("does not reload history for local run with empty final when another run is active (#53115)", () => {
diff --git a/src/tui/tui-event-handlers.ts b/src/tui/tui-event-handlers.ts
@@ -22,7 +22,7 @@ type EventHandlerChatLog = {
 };
 
 type EventHandlerTui = {
-  requestRender: () => void;
+  requestRender: (force?: boolean) => void;
 };
 
 type EventHandlerBtwPresenter = {
@@ -489,7 +489,7 @@ export function createEventHandlers(context: EventHandlerContext) {
         forgetLocalBtwRunId?.(evt.runId);
         noteFinalizedRun(evt.runId);
         clearStaleStreamingIfNoTrackedRunRemains();
-        tui.requestRender();
+        tui.requestRender(true);
         return;
       }
       if (!evt.message) {
@@ -498,7 +498,7 @@ export function createEventHandlers(context: EventHandlerContext) {
         });
         chatLog.dropAssistant(evt.runId);
         finalizeRun({ runId: evt.runId, wasActiveRun, status: "idle" });
-        tui.requestRender();
+        tui.requestRender(true);
         return;
       }
       if (isCommandMessage(evt.message)) {
@@ -508,7 +508,7 @@ export function createEventHandlers(context: EventHandlerContext) {
           chatLog.addSystem(text);
         }
         finalizeRun({ runId: evt.runId, wasActiveRun, status: "idle", displayedFinal: true });
-        tui.requestRender();
+        tui.requestRender(true);
         return;
       }
       maybeRefreshHistoryForRun(evt.runId);
