fix: restrict HTML timeout short-circuit to transient statuses

obviyus · obviyus · commit de129a6530c0 · 2026-04-16T18:33:35.000+05:30
diff --git a/src/agents/pi-embedded-helpers.formatassistanterrortext.test.ts b/src/agents/pi-embedded-helpers.formatassistanterrortext.test.ts
@@ -176,7 +176,7 @@ describe("formatAssistantErrorText", () => {
     );
   });
 
-  it("returns upstream HTML copy for prefixed HTML rate-limit pages", () => {
+  it("returns upstream HTML copy for prefixed 521 HTML rate-limit pages", () => {
     const msg = makeAssistantError(
       "Error: 521 <!DOCTYPE html><html><body>rate limit</body></html>",
     );
diff --git a/src/agents/pi-embedded-helpers/errors.ts b/src/agents/pi-embedded-helpers/errors.ts
@@ -354,7 +354,11 @@ function isHtmlErrorResponse(raw: string, status?: number): boolean {
 }
 
 function isTransportHtmlErrorStatus(status: number | undefined): boolean {
-  return status !== 401 && status !== 403 && status !== 407;
+  return (
+    status === 408 ||
+    status === 499 ||
+    (typeof status === "number" && status >= 500 && status < 600)
+  );
 }
 
 function isOpenAICodexScopeContext(raw: string, provider?: string): boolean {
diff --git a/src/agents/pi-embedded-helpers/provider-error-patterns.test.ts b/src/agents/pi-embedded-helpers/provider-error-patterns.test.ts
@@ -167,6 +167,12 @@ describe("Cloudflare / CDN HTML error page classification (#67517)", () => {
   const html407 =
     "<!doctype html><html><head><title>407 Proxy Authentication Required</title></head>" +
     "<body><h1>Proxy Authentication Required</h1></body></html>";
+  const html402 =
+    "<!doctype html><html><head><title>402 Payment Required</title></head>" +
+    "<body><h1>Payment Required</h1><p>Your quota is exhausted.</p></body></html>";
+  const html429 =
+    "<!doctype html><html><head><title>429 Too Many Requests</title></head>" +
+    "<body><h1>Too Many Requests</h1><p>Rate limit exceeded.</p></body></html>";
   const prefixedHtml401 = `Error: 401 ${html401}`;
   const prefixedHtml407 = `Error: 407 ${html407}`;
 
@@ -190,6 +196,14 @@ describe("Cloudflare / CDN HTML error page classification (#67517)", () => {
     expect(classifyFailoverReason(prefixedHtml401)).toBe("auth");
   });
 
+  it("preserves billing classification for 402 HTML", () => {
+    expect(classifyFailoverReason(`402 ${html402}`)).toBe("billing");
+  });
+
+  it("preserves rate-limit classification for 429 HTML", () => {
+    expect(classifyFailoverReason(`429 ${html429}`)).toBe("rate_limit");
+  });
+
   it("classifies runtime failure kind as upstream_html for non-auth HTML", () => {
     expect(classifyProviderRuntimeFailureKind({ status: 502, message: cloudflareHtml502 })).toBe(
       "upstream_html",

Original file line number	Diff line number	Diff line change
`@@ -354,7 +354,11 @@ function isHtmlErrorResponse(raw: string, status?: number): boolean {`
`354`	`354`	`}`
`355`	`355`
`356`	`356`	`function isTransportHtmlErrorStatus(status: number \| undefined): boolean {`
`357`		`- return status !== 401 && status !== 403 && status !== 407;`
	`357`	`+ return (`
	`358`	`+ status === 408 \|\|`
	`359`	`+ status === 499 \|\|`
	`360`	`+ (typeof status === "number" && status >= 500 && status < 600)`
	`361`	`+ );`
`358`	`362`	`}`
`359`	`363`
`360`	`364`	`function isOpenAICodexScopeContext(raw: string, provider?: string): boolean {`