fix(ci): keep sufficient proof on label churn

Takhoffman · Takhoffman · commit d86adea24c08 · 2026-05-18T13:44:27.000-05:00
diff --git a/scripts/github/barnacle-auto-response.mjs b/scripts/github/barnacle-auto-response.mjs
@@ -801,10 +801,13 @@ function shouldRemoveProofSufficientLabel(context, proofEvaluation, hasExactHead
   if (proofEvaluation.status === "override") {
     return false;
   }
+  if (!["edited", "synchronize"].includes(context.payload.action)) {
+    return false;
+  }
   if (proofEvaluation.status !== "passed") {
     return true;
   }
-  return ["edited", "synchronize"].includes(context.payload.action);
+  return true;
 }
 
 async function applyPullRequestCandidateLabels(github, context, core, pullRequest, labelSet) {
diff --git a/test/scripts/barnacle-auto-response.test.ts b/test/scripts/barnacle-auto-response.test.ts
@@ -872,6 +872,24 @@ describe("barnacle-auto-response", () => {
     expect(calls.removeLabel).toEqual([]);
   });
 
+  it("preserves sufficient proof on unrelated label events even without body proof", async () => {
+    const { calls, github } = barnacleGithub([file("src/gateway/server.ts")]);
+
+    await runBarnacleAutoResponse({
+      github,
+      context: barnacleContext({}, [PROOF_SUFFICIENT_LABEL], {
+        action: "labeled",
+        label: { name: "status: ready for maintainer look" },
+        sender: { login: "openclaw-clawsweeper[bot]", type: "Bot" },
+      }),
+      core: {
+        info: () => undefined,
+      },
+    });
+
+    expect(calls.removeLabel).toEqual([]);
+  });
+
   it("does not let Barnacle veto ClawSweeper's sufficient proof label add", async () => {
     const { calls, github } = barnacleGithub([file("src/gateway/server.ts")]);
 

Original file line number	Diff line number	Diff line change
`@@ -801,10 +801,13 @@ function shouldRemoveProofSufficientLabel(context, proofEvaluation, hasExactHead`
`801`	`801`	`if (proofEvaluation.status === "override") {`
`802`	`802`	`return false;`
`803`	`803`	`}`
	`804`	`+ if (!["edited", "synchronize"].includes(context.payload.action)) {`
	`805`	`+ return false;`
	`806`	`+ }`
`804`	`807`	`if (proofEvaluation.status !== "passed") {`
`805`	`808`	`return true;`
`806`	`809`	`}`
`807`		`- return ["edited", "synchronize"].includes(context.payload.action);`
	`810`	`+ return true;`
`808`	`811`	`}`
`809`	`812`
`810`	`813`	`async function applyPullRequestCandidateLabels(github, context, core, pullRequest, labelSet) {`