test(cron): cover default timeout fallback budget

sakaenyeniceri5 · sakaenyeniceri5 · commit d5591c3868c9 · 2026-05-07T21:29:12.000-07:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -170,6 +170,7 @@ Docs: https://docs.openclaw.ai
 
 ### Fixes
 
+- fix(cron): skip model fallback when attempt budget is exhausted. Thanks @imwyvern.
 - Control UI/chat: hide retired and non-public Google Gemini model IDs from chat model catalogs and route the bare `gemini-3-pro` alias to Gemini 3.1 Pro Preview instead of the shut-down Gemini 3 Pro Preview. Thanks @BunsDev.
 - CLI/install: refuse state-mutating OpenClaw CLI runs as root by default, keep an explicit `OPENCLAW_ALLOW_ROOT=1` escape hatch for intentional root/container use, and update DigitalOcean setup guidance to run OpenClaw as a non-root user. Fixes #67478. Thanks @Jerry-Xin and @natechicago.
 - Gateway/watch: leave `OPENCLAW_TRACE_SYNC_IO` disabled by default in `pnpm gateway:watch:raw` so watch mode avoids noisy Node sync-I/O stack traces unless explicitly requested.
diff --git a/src/cron/isolated-agent/run.fallback-time-budget.test.ts b/src/cron/isolated-agent/run.fallback-time-budget.test.ts
@@ -77,6 +77,72 @@ describe("runCronIsolatedAgentTurn — fallback time budget", () => {
     }
   });
 
+  it("uses agents.defaults.timeoutSeconds for fallback budget when job timeoutSeconds is unset", async () => {
+    const { resolveAgentTimeoutMs } = await import("./run.runtime.js");
+    vi.mocked(resolveAgentTimeoutMs).mockReturnValue(5_000);
+
+    let secondAttemptGate:
+      | {
+          type: "stop";
+          reason?: string | null;
+          error?: string;
+        }
+      | undefined = undefined;
+    const nowMs = Date.parse("2026-03-23T12:00:00.000Z");
+    const dateNowSpy = vi.spyOn(Date, "now").mockReturnValue(nowMs);
+
+    runWithModelFallbackMock.mockImplementationOnce(async (params) => {
+      expect(params.beforeAttempt).toBeTypeOf("function");
+
+      secondAttemptGate = await params.beforeAttempt?.({
+        candidate: { provider: "openai-codex", model: "gpt-5.4" },
+        attempt: 2,
+        total: 2,
+        previousAttempts: [
+          {
+            provider: "anthropic",
+            model: "claude-opus-4-6",
+            error: "Request was aborted.",
+            reason: "unknown",
+          },
+        ],
+        isPrimary: false,
+        requestedModelMatched: false,
+        fallbackConfigured: true,
+      });
+
+      return {
+        result: {
+          payloads: [{ text: "done" }],
+          meta: { agentMeta: { usage: { input: 10, output: 20 } } },
+        },
+        provider: "anthropic",
+        model: "claude-opus-4-6",
+        attempts: [],
+      };
+    });
+
+    try {
+      const result = await runCronIsolatedAgentTurn(
+        makeIsolatedAgentTurnParams({
+          cfg: { agents: { defaults: { timeoutSeconds: 5 } } },
+          deadlineAtMs: nowMs + 10_000,
+          job: makeIsolatedAgentTurnJob({
+            payload: { kind: "agentTurn", message: "test" },
+          }),
+        }),
+      );
+
+      expect(result.status).toBe("ok");
+      expect(resolveAgentTimeoutMs).toHaveBeenCalledWith(
+        expect.objectContaining({ overrideSeconds: undefined }),
+      );
+      expect(secondAttemptGate).toBeUndefined();
+    } finally {
+      dateNowSpy.mockRestore();
+    }
+  });
+
   it("stops new fallback attempts when the per-attempt budget no longer fits", async () => {
     let secondAttemptGate:
       | {
