fix(ci): preserve Barnacle proof labels (#83735)

Takhoffman · web-flow · commit c92ebd6a4104 · 2026-05-18T14:37:20.000-05:00
* fix(ci): preserve sufficient proof override

* fix(ci): keep sufficient proof on label churn
diff --git a/scripts/github/barnacle-auto-response.mjs b/scripts/github/barnacle-auto-response.mjs
@@ -798,10 +798,16 @@ function shouldRemoveProofSufficientLabel(context, proofEvaluation, hasExactHead
   if (hasExactHeadClawSweeperProof) {
     return false;
   }
+  if (proofEvaluation.status === "override") {
+    return false;
+  }
+  if (!["edited", "synchronize"].includes(context.payload.action)) {
+    return false;
+  }
   if (proofEvaluation.status !== "passed") {
     return true;
   }
-  return ["edited", "synchronize"].includes(context.payload.action);
+  return true;
 }
 
 async function applyPullRequestCandidateLabels(github, context, core, pullRequest, labelSet) {
diff --git a/test/scripts/barnacle-auto-response.test.ts b/test/scripts/barnacle-auto-response.test.ts
@@ -6,6 +6,7 @@ import {
   runBarnacleAutoResponse,
 } from "../../scripts/github/barnacle-auto-response.mjs";
 import {
+  PROOF_OVERRIDE_LABEL,
   PROOF_SUFFICIENT_LABEL,
   PROOF_SUPPLIED_LABEL,
 } from "../../scripts/github/real-behavior-proof-policy.mjs";
@@ -716,7 +717,7 @@ describe("barnacle-auto-response", () => {
     expect(calls.update).toStrictEqual([]);
   });
 
-  it("removes stale proof labels when override is present", async () => {
+  it("removes stale structural proof labels but preserves sufficient proof when override is present", async () => {
     const { calls, github } = barnacleGithub([file("src/gateway/server.ts")]);
 
     await runBarnacleAutoResponse({
@@ -726,7 +727,7 @@ describe("barnacle-auto-response", () => {
         candidateLabels.mockOnlyProof,
         PROOF_SUPPLIED_LABEL,
         PROOF_SUFFICIENT_LABEL,
-        "proof: override",
+        PROOF_OVERRIDE_LABEL,
       ]),
       core: {
         info: () => undefined,
@@ -737,11 +738,38 @@ describe("barnacle-auto-response", () => {
       expectedRemoveLabel(123, candidateLabels.needsRealBehaviorProof),
       expectedRemoveLabel(123, candidateLabels.mockOnlyProof),
       expectedRemoveLabel(123, PROOF_SUPPLIED_LABEL),
-      expectedRemoveLabel(123, PROOF_SUFFICIENT_LABEL),
     ]);
     expect(calls.update).toStrictEqual([]);
   });
 
+  it("preserves manually applied sufficient proof label when override is added", async () => {
+    const { calls, github } = barnacleGithub([file("src/gateway/server.ts")]);
+
+    await runBarnacleAutoResponse({
+      github,
+      context: barnacleContext(
+        {
+          body: realBehaviorProofBody(
+            "![after](https://github.com/user-attachments/assets/gateway-ready)",
+          ),
+        },
+        [PROOF_OVERRIDE_LABEL, PROOF_SUFFICIENT_LABEL],
+        {
+          action: "labeled",
+          label: { name: PROOF_OVERRIDE_LABEL },
+          sender: { login: "maintainer", type: "User" },
+        },
+      ),
+      core: {
+        info: () => undefined,
+      },
+    });
+
+    expect(calls.removeLabel).toEqual([]);
+    expect(calls.addLabels).toEqual([]);
+    expect(calls.update).toEqual([]);
+  });
+
   it("removes stale negative proof labels and adds supplied when proof is present", async () => {
     const { calls, github } = barnacleGithub([file("src/gateway/server.ts")]);
 
@@ -887,6 +915,24 @@ describe("barnacle-auto-response", () => {
     expect(calls.removeLabel).toEqual([]);
   });
 
+  it("preserves sufficient proof on unrelated label events even without body proof", async () => {
+    const { calls, github } = barnacleGithub([file("src/gateway/server.ts")]);
+
+    await runBarnacleAutoResponse({
+      github,
+      context: barnacleContext({}, [PROOF_SUFFICIENT_LABEL], {
+        action: "labeled",
+        label: { name: "status: ready for maintainer look" },
+        sender: { login: "openclaw-clawsweeper[bot]", type: "Bot" },
+      }),
+      core: {
+        info: () => undefined,
+      },
+    });
+
+    expect(calls.removeLabel).toEqual([]);
+  });
+
   it("does not let Barnacle veto ClawSweeper's sufficient proof label add", async () => {
     const { calls, github } = barnacleGithub([file("src/gateway/server.ts")]);
 

Original file line number	Diff line number	Diff line change
`@@ -798,10 +798,16 @@ function shouldRemoveProofSufficientLabel(context, proofEvaluation, hasExactHead`
`798`	`798`	`if (hasExactHeadClawSweeperProof) {`
`799`	`799`	`return false;`
`800`	`800`	`}`
	`801`	`+ if (proofEvaluation.status === "override") {`
	`802`	`+ return false;`
	`803`	`+ }`
	`804`	`+ if (!["edited", "synchronize"].includes(context.payload.action)) {`
	`805`	`+ return false;`
	`806`	`+ }`
`801`	`807`	`if (proofEvaluation.status !== "passed") {`
`802`	`808`	`return true;`
`803`	`809`	`}`
`804`		`- return ["edited", "synchronize"].includes(context.payload.action);`
	`810`	`+ return true;`
`805`	`811`	`}`
`806`	`812`
`807`	`813`	`async function applyPullRequestCandidateLabels(github, context, core, pullRequest, labelSet) {`