fix(agents): do not refresh lastUsedAt on MCP lease release

clawsweeper[bot] · clawsweeper[bot] · commit c9144789fd8b · 2026-06-08T01:58:22.000Z
diff --git a/src/agents/agent-bundle-mcp-runtime.test.ts b/src/agents/agent-bundle-mcp-runtime.test.ts
@@ -7,12 +7,12 @@ import { afterEach, describe, expect, it, vi } from "vitest";
 import { createBundleMcpJsonSchemaValidator } from "./agent-bundle-mcp-runtime.js";
 import { cleanupBundleMcpHarness } from "./agent-bundle-mcp-test-harness.js";
 import {
-  testing,
   createSessionMcpRuntime,
   getOrCreateSessionMcpRuntime,
   materializeBundleMcpToolsForRun,
   retireSessionMcpRuntime,
   retireSessionMcpRuntimeForSessionKey,
+  testing,
 } from "./agent-bundle-mcp-tools.js";
 import type { SessionMcpRuntime } from "./agent-bundle-mcp-types.js";
 import { writeExecutable } from "./bundle-mcp-shared.test-harness.js";
@@ -1672,12 +1672,12 @@ process.on("SIGINT", shutdown);`,
     });
     const releaseLease = runtime.acquireLease?.();
 
-    // TTL elapses while the lease is still held — sweep skips active runtimes
+    // TTL elapses while the lease is still held, so sweep skips active runtimes.
     now += 60;
     await expect(manager.sweepIdleRuntimes()).resolves.toBe(0);
 
-    // Release the lease — must not reset lastUsedAt, so the runtime is
-    // evictable on the very next sweep without waiting another full TTL
+    // Release must not reset lastUsedAt; the runtime is evictable on the very
+    // next sweep without waiting another full TTL.
     releaseLease?.();
     await expect(manager.sweepIdleRuntimes()).resolves.toBe(1);
 
@@ -1722,6 +1722,9 @@ process.on("SIGINT", shutdown);`,
       cfg: { mcp: { servers: {} } },
     });
     const lastUsedBefore = runtime.lastUsedAt;
+    if (!runtime.acquireLease) {
+      throw new Error("Expected production session MCP runtime to expose acquireLease");
+    }
     const release = runtime.acquireLease();
     release();
     expect(runtime.lastUsedAt).toBe(lastUsedBefore);
diff --git a/src/agents/agent-bundle-mcp-runtime.ts b/src/agents/agent-bundle-mcp-runtime.ts
@@ -765,7 +765,7 @@ export function createSessionMcpRuntime(params: {
         }
         released = true;
         activeLeases = Math.max(0, activeLeases - 1);
-        // release ≠ use: refreshing lastUsedAt here defeats the idle-sweep TTL.
+        // Release is not use: refreshing lastUsedAt here defeats the idle-sweep TTL.
       };
     },
     getCatalog,

Original file line number	Diff line number	Diff line change
`@@ -765,7 +765,7 @@ export function createSessionMcpRuntime(params: {`
`765`	`765`	`}`
`766`	`766`	`released = true;`
`767`	`767`	`activeLeases = Math.max(0, activeLeases - 1);`
`768`		`- // release ≠ use: refreshing lastUsedAt here defeats the idle-sweep TTL.`
	`768`	`+ // Release is not use: refreshing lastUsedAt here defeats the idle-sweep TTL.`
`769`	`769`	`};`
`770`	`770`	`},`
`771`	`771`	`getCatalog,`