Skip to content

Commit c8ee335

Browse files
committed
fix(discord): deliver finals in progress mode
1 parent 1c778f7 commit c8ee335

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

extensions/discord/src/monitor/message-handler.process.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1712,6 +1712,7 @@ describe("processDiscordMessage draft streaming", () => {
17121712

17131713
it("defaults unset Discord preview streaming to progress mode without drafting text-only turns", async () => {
17141714
await runSingleChunkFinalScenario({ maxLinesPerMessage: 5 });
1715+
expect(getLastDispatchReplyOptions()?.onPartialReply).toBeUndefined();
17151716
expect(createDiscordDraftStream).toHaveBeenCalledTimes(1);
17161717
expect(editMessageDiscord).not.toHaveBeenCalled();
17171718
expect(deliverDiscordReply).toHaveBeenCalledTimes(1);

extensions/discord/src/monitor/message-handler.process.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -808,9 +808,10 @@ export async function processDiscordMessage(
808808
(typeof resolvedBlockStreamingEnabled === "boolean"
809809
? !resolvedBlockStreamingEnabled
810810
: undefined)),
811-
onPartialReply: draftPreview.draftStream
812-
? (payload) => draftPreview.updateFromPartial(payload.text)
813-
: undefined,
811+
onPartialReply:
812+
draftPreview.draftStream && !draftPreview.isProgressMode
813+
? (payload) => draftPreview.updateFromPartial(payload.text)
814+
: undefined,
814815
onAssistantMessageStart: draftPreview.draftStream
815816
? () => draftPreview.handleAssistantMessageBoundary()
816817
: undefined,

0 commit comments

Comments
 (0)