fix(browser): guard setDeep against empty keys array

zhangLei99586 · vincentkoc · commit c6a5303d666c · 2026-07-01T17:20:06.000-07:00
When keys is empty, keys[keys.length - 1] returns undefined, and the
previous ??  fallback would silently create a property with an empty
string key on the target object. Add an early return so empty keys are
a no-op instead of silently polluting the object.
diff --git a/extensions/browser/src/browser/chrome.profile-decoration.ts b/extensions/browser/src/browser/chrome.profile-decoration.ts
@@ -38,6 +38,9 @@ function readNestedRecord(root: unknown, key: string): Record<string, unknown> |
 }
 
 function setDeep(obj: Record<string, unknown>, keys: string[], value: unknown) {
+  if (keys.length === 0) {
+    return;
+  }
   let node: Record<string, unknown> = obj;
   for (const key of keys.slice(0, -1)) {
     const next = node[key];
@@ -46,7 +49,7 @@ function setDeep(obj: Record<string, unknown>, keys: string[], value: unknown) {
     }
     node = node[key] as Record<string, unknown>;
   }
-  node[keys[keys.length - 1] ?? ""] = value;
+  node[keys[keys.length - 1]] = value;
 }
 
 function parseHexRgbToSignedArgbInt(hex: string): number | null {

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,9 @@ function readNestedRecord(root: unknown, key: string): Record<string, unknown> \|`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`function setDeep(obj: Record<string, unknown>, keys: string[], value: unknown) {`
	`41`	`+ if (keys.length === 0) {`
	`42`	`+ return;`
	`43`	`+ }`
`41`	`44`	`let node: Record<string, unknown> = obj;`
`42`	`45`	`for (const key of keys.slice(0, -1)) {`
`43`	`46`	`const next = node[key];`
`@@ -46,7 +49,7 @@ function setDeep(obj: Record<string, unknown>, keys: string[], value: unknown) {`
`46`	`49`	`}`
`47`	`50`	`node = node[key] as Record<string, unknown>;`
`48`	`51`	`}`
`49`		`- node[keys[keys.length - 1] ?? ""] = value;`
	`52`	`+ node[keys[keys.length - 1]] = value;`
`50`	`53`	`}`
`51`	`54`
`52`	`55`	`function parseHexRgbToSignedArgbInt(hex: string): number \| null {`