test: tighten codex binding assertions

steipete · steipete · commit c20d45e34699 · 2026-05-11T14:40:27.000+01:00
diff --git a/extensions/codex/src/app-server/auth-profile-runtime-contract.test.ts b/extensions/codex/src/app-server/auth-profile-runtime-contract.test.ts
@@ -212,8 +212,7 @@ describe("Auth profile runtime contract - Codex app-server adapter", () => {
     await harness.completeTurn();
     await run;
 
-    await expect(readCodexAppServerBinding(sessionFile)).resolves.toMatchObject({
-      authProfileId: AUTH_PROFILE_RUNTIME_CONTRACT.openAiCodexProfileId,
-    });
+    const binding = await readCodexAppServerBinding(sessionFile);
+    expect(binding?.authProfileId).toBe(AUTH_PROFILE_RUNTIME_CONTRACT.openAiCodexProfileId);
   });
 });
diff --git a/extensions/codex/src/app-server/models.test.ts b/extensions/codex/src/app-server/models.test.ts
@@ -192,9 +192,8 @@ describe("listCodexAppServerModels", () => {
       },
     });
 
-    await expect(listPromise).resolves.toMatchObject({
-      models: [{ id: "gpt-5.4" }, { id: "gpt-5.2" }],
-    });
+    const list = await listPromise;
+    expect(list.models.map((model) => model.id)).toEqual(["gpt-5.4", "gpt-5.2"]);
     harness.client.close();
     startSpy.mockRestore();
   });
@@ -237,11 +236,10 @@ describe("listCodexAppServerModels", () => {
       },
     });
 
-    await expect(listPromise).resolves.toMatchObject({
-      models: [{ id: "gpt-5.4" }],
-      nextCursor: "page-2",
-      truncated: true,
-    });
+    const list = await listPromise;
+    expect(list.models.map((model) => model.id)).toEqual(["gpt-5.4"]);
+    expect(list.nextCursor).toBe("page-2");
+    expect(list.truncated).toBe(true);
     harness.client.close();
     startSpy.mockRestore();
   });
diff --git a/extensions/codex/src/app-server/session-binding.test.ts b/extensions/codex/src/app-server/session-binding.test.ts
@@ -48,15 +48,13 @@ describe("codex app-server session binding", () => {
 
     const binding = await readCodexAppServerBinding(sessionFile);
 
-    expect(binding).toMatchObject({
-      schemaVersion: 1,
-      threadId: "thread-123",
-      sessionFile,
-      cwd: tempDir,
-      model: "gpt-5.4-codex",
-      modelProvider: "openai",
-      dynamicToolsFingerprint: "tools-v1",
-    });
+    expect(binding?.schemaVersion).toBe(1);
+    expect(binding?.threadId).toBe("thread-123");
+    expect(binding?.sessionFile).toBe(sessionFile);
+    expect(binding?.cwd).toBe(tempDir);
+    expect(binding?.model).toBe("gpt-5.4-codex");
+    expect(binding?.modelProvider).toBe("openai");
+    expect(binding?.dynamicToolsFingerprint).toBe("tools-v1");
     const bindingStat = await fs.stat(resolveCodexAppServerBindingPath(sessionFile));
     expect(bindingStat.isFile()).toBe(true);
   });
@@ -142,11 +140,9 @@ describe("codex app-server session binding", () => {
     const binding = await readCodexAppServerBinding(sessionFile, nativeAuthLookup);
 
     expect(raw).not.toContain('"modelProvider": "openai"');
-    expect(binding).toMatchObject({
-      threadId: "thread-123",
-      authProfileId: "work",
-      model: "gpt-5.4-mini",
-    });
+    expect(binding?.threadId).toBe("thread-123");
+    expect(binding?.authProfileId).toBe("work");
+    expect(binding?.model).toBe("gpt-5.4-mini");
     expect(binding?.modelProvider).toBeUndefined();
   });
 
diff --git a/extensions/codex/src/app-server/thread-lifecycle.test.ts b/extensions/codex/src/app-server/thread-lifecycle.test.ts
@@ -132,7 +132,7 @@ describe("Codex app-server model provider selection", () => {
       },
     );
 
-    expect(request).toMatchObject({ modelProvider: "openai" });
+    expect(request.modelProvider).toBe("openai");
   });
 
   it("keeps public OpenAI modelProvider when no native Codex auth profile is selected", () => {
@@ -143,7 +143,7 @@ describe("Codex app-server model provider selection", () => {
       developerInstructions: "test instructions",
     });
 
-    expect(request).toMatchObject({ modelProvider: "openai" });
+    expect(request.modelProvider).toBe("openai");
   });
 });
 
diff --git a/extensions/codex/src/conversation-control.test.ts b/extensions/codex/src/conversation-control.test.ts
@@ -53,12 +53,11 @@ describe("codex conversation controls", () => {
       "Codex permissions set to default.",
     );
 
-    await expect(readCodexAppServerBinding(sessionFile)).resolves.toMatchObject({
-      threadId: "thread-1",
-      serviceTier: "priority",
-      approvalPolicy: "on-request",
-      sandbox: "workspace-write",
-    });
+    const binding = await readCodexAppServerBinding(sessionFile);
+    expect(binding?.threadId).toBe("thread-1");
+    expect(binding?.serviceTier).toBe("priority");
+    expect(binding?.approvalPolicy).toBe("on-request");
+    expect(binding?.sandbox).toBe("workspace-write");
   });
 
   it("does not persist public OpenAI provider after model changes on native auth bindings", async () => {
@@ -95,11 +94,9 @@ describe("codex conversation controls", () => {
     const raw = await fs.readFile(`${sessionFile}.codex-app-server.json`, "utf8");
     const binding = await readCodexAppServerBinding(sessionFile);
     expect(raw).not.toContain('"modelProvider": "openai"');
-    expect(binding).toMatchObject({
-      threadId: "thread-1",
-      authProfileId: "work",
-      model: "gpt-5.5",
-    });
+    expect(binding?.threadId).toBe("thread-1");
+    expect(binding?.authProfileId).toBe("work");
+    expect(binding?.model).toBe("gpt-5.5");
     expect(binding?.modelProvider).toBeUndefined();
   });
 
