fix(perf): reject loose extension memory numeric flags

vincentkoc · vincentkoc · commit bf22893cb6e9 · 2026-05-28T04:57:51.000+02:00
diff --git a/scripts/profile-extension-memory.mjs b/scripts/profile-extension-memory.mjs
@@ -37,8 +37,12 @@ Examples:
 }
 
 function parsePositiveInt(raw, flagName) {
-  const parsed = Number.parseInt(raw, 10);
-  if (!Number.isFinite(parsed) || parsed <= 0) {
+  const text = String(raw ?? "").trim();
+  if (!/^\d+$/u.test(text)) {
+    throw new Error(`${flagName} must be a positive integer`);
+  }
+  const parsed = Number(text);
+  if (!Number.isSafeInteger(parsed) || parsed <= 0) {
     throw new Error(`${flagName} must be a positive integer`);
   }
   return parsed;
diff --git a/test/scripts/profile-extension-memory.test.ts b/test/scripts/profile-extension-memory.test.ts
@@ -0,0 +1,38 @@
+import { spawnSync } from "node:child_process";
+import { describe, expect, it } from "vitest";
+
+function runProfileExtensionMemory(args: string[]) {
+  return spawnSync(process.execPath, ["scripts/profile-extension-memory.mjs", ...args], {
+    cwd: process.cwd(),
+    encoding: "utf8",
+  });
+}
+
+describe("scripts/profile-extension-memory", () => {
+  it("prints help without requiring built plugin artifacts", () => {
+    const result = runProfileExtensionMemory(["--help"]);
+
+    expect(result.status).toBe(0);
+    expect(result.stderr).toBe("");
+    expect(result.stdout).toContain("Usage: node scripts/profile-extension-memory.mjs");
+  });
+
+  it("rejects loose numeric flags before scanning built plugin artifacts", () => {
+    const cases = [
+      ["--concurrency", "2abc"],
+      ["--timeout-ms", "1e3"],
+      ["--combined-timeout-ms", "90000ms"],
+      ["--top", "0x10"],
+    ];
+
+    for (const [flag, value] of cases) {
+      const result = runProfileExtensionMemory([flag, value]);
+
+      expect(result.status).toBe(1);
+      expect(result.stdout).toBe("");
+      expect(result.stderr).toContain(`[extension-memory] ${flag} must be a positive integer`);
+      expect(result.stderr).not.toContain("dist/extensions");
+      expect(result.stderr).not.toContain("at ");
+    }
+  });
+});

Original file line number	Diff line number	Diff line change
`@@ -37,8 +37,12 @@ Examples:`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`function parsePositiveInt(raw, flagName) {`
`40`		`- const parsed = Number.parseInt(raw, 10);`
`41`		`- if (!Number.isFinite(parsed) \|\| parsed <= 0) {`
	`40`	`+ const text = String(raw ?? "").trim();`
	`41`	`+ if (!/^\d+$/u.test(text)) {`
	`42`	+ throw new Error(`${flagName} must be a positive integer`);
	`43`	`+ }`
	`44`	`+ const parsed = Number(text);`
	`45`	`+ if (!Number.isSafeInteger(parsed) \|\| parsed <= 0) {`
`42`	`46`	throw new Error(`${flagName} must be a positive integer`);
`43`	`47`	`}`
`44`	`48`	`return parsed;`