fix(clownfish): address review for ghcrawl-156980-autonomous-smoke (1)

vincentkoc · vincentkoc · commit bdc3b6ef0e1d · 2026-04-28T07:54:50.000Z
diff --git a/extensions/feishu/src/bot-sender-name.test.ts b/extensions/feishu/src/bot-sender-name.test.ts
@@ -196,4 +196,42 @@ describe("resolveFeishuSenderName", () => {
       }),
     );
   });
+
+  it("keeps direct-member permission guidance when contact fallback hits stale contact scope", async () => {
+    const account = makeAccount("default");
+    const { client } = mockClient({
+      memberError: {
+        response: {
+          data: {
+            code: 99991672,
+            msg: "permission denied https://open.feishu.cn/app/cli_default",
+          },
+        },
+      },
+      contactError: {
+        response: {
+          data: {
+            code: 99991672,
+            msg: "permission denied: contact:contact.base:readonly https://open.feishu.cn/app/cli_default",
+          },
+        },
+      },
+    });
+    mockCreateFeishuClient.mockReturnValue(client);
+
+    const result = await resolveFeishuSenderName({
+      account,
+      senderId: "ou_sender",
+      chatId: "oc_dm",
+      chatType: "p2p",
+      log,
+    });
+
+    expect(result.permissionError).toEqual(
+      expect.objectContaining({
+        code: 99991672,
+        grantUrl: "https://open.feishu.cn/app/cli_default",
+      }),
+    );
+  });
 });
diff --git a/extensions/feishu/src/bot-sender-name.ts b/extensions/feishu/src/bot-sender-name.ts
@@ -222,7 +222,7 @@ export async function resolveFeishuSenderName(params: {
     if (permErr) {
       if (shouldSuppressPermissionErrorNotice(permErr)) {
         log(`feishu: ignoring stale permission scope error: ${permErr.message}`);
-        return {};
+        return directPermissionError ? { permissionError: directPermissionError } : {};
       }
       log(`feishu: permission error resolving sender name: code=${permErr.code}`);
       return { permissionError: permErr };

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,7 @@ export async function resolveFeishuSenderName(params: {`
`222`	`222`	`if (permErr) {`
`223`	`223`	`if (shouldSuppressPermissionErrorNotice(permErr)) {`
`224`	`224`	log(`feishu: ignoring stale permission scope error: ${permErr.message}`);
`225`		`- return {};`
	`225`	`+ return directPermissionError ? { permissionError: directPermissionError } : {};`
`226`	`226`	`}`
`227`	`227`	log(`feishu: permission error resolving sender name: code=${permErr.code}`);
`228`	`228`	`return { permissionError: permErr };`