fix(e2e): clean plugin lifecycle temp state

vincentkoc · vincentkoc · commit ba88b7a1780f · 2026-06-01T19:27:04.000+02:00
diff --git a/scripts/e2e/lib/plugin-lifecycle-matrix/sweep.sh b/scripts/e2e/lib/plugin-lifecycle-matrix/sweep.sh
@@ -20,6 +20,25 @@ package_name="@openclaw/lifecycle-claw"
 probe="scripts/e2e/lib/plugin-lifecycle-matrix/probe.mjs"
 measure="scripts/e2e/lib/plugin-lifecycle-matrix/measure.mjs"
 resource_dir="/tmp/openclaw-plugin-lifecycle-matrix"
+pack_root=""
+registry_root=""
+
+cleanup() {
+  openclaw_plugins_cleanup_fixture_servers
+  rm -rf "$resource_dir"
+  if [ -n "$pack_root" ]; then
+    rm -rf "$pack_root"
+  fi
+  if [ -n "$registry_root" ]; then
+    rm -rf "$registry_root"
+  fi
+  rm -f \
+    /tmp/lifecycle-claw-1.0.0.tgz \
+    /tmp/lifecycle-claw-2.0.0.tgz \
+    /tmp/plugin-lifecycle-inspect-v1.json
+}
+trap cleanup EXIT
+
 mkdir -p "$resource_dir"
 summary_tsv="$resource_dir/resource-summary.tsv"
 printf "phase\tmax_rss_kb\tcpu_seconds\twall_ms\tcpu_core_ratio\tsignal\n" >"$summary_tsv"
@@ -37,6 +56,7 @@ registry_root="$(mktemp -d "/tmp/openclaw-plugin-lifecycle-registry.XXXXXX")"
 pack_fixture_plugin "$pack_root/v1" /tmp/lifecycle-claw-1.0.0.tgz "$plugin_id" 1.0.0 lifecycle.v1 "Lifecycle Claw"
 pack_fixture_plugin "$pack_root/v2" /tmp/lifecycle-claw-2.0.0.tgz "$plugin_id" 2.0.0 lifecycle.v2 "Lifecycle Claw"
 start_npm_fixture_registry "$package_name" 1.0.0 /tmp/lifecycle-claw-1.0.0.tgz "$registry_root" "$package_name" 2.0.0 /tmp/lifecycle-claw-2.0.0.tgz
+trap cleanup EXIT
 
 run_measured install-v1 node "$entry" plugins install "npm:$package_name@1.0.0"
 node "$probe" assert-version "$plugin_id" 1.0.0
diff --git a/test/scripts/docker-build-helper.test.ts b/test/scripts/docker-build-helper.test.ts
@@ -64,6 +64,7 @@ const PLUGIN_UPDATE_CORRUPT_SCENARIO_PATH =
   "scripts/e2e/lib/plugin-update/corrupt-update-scenario.sh";
 const PLUGIN_UPDATE_PROBE_PATH = "scripts/e2e/lib/plugin-update/probe.mjs";
 const PLUGIN_LIFECYCLE_MATRIX_DOCKER_E2E_PATH = "scripts/e2e/plugin-lifecycle-matrix-docker.sh";
+const PLUGIN_LIFECYCLE_MATRIX_SWEEP_PATH = "scripts/e2e/lib/plugin-lifecycle-matrix/sweep.sh";
 const DOCTOR_SWITCH_DOCKER_E2E_PATH = "scripts/e2e/doctor-install-switch-docker.sh";
 const DOCTOR_SWITCH_SCENARIO_PATH = "scripts/e2e/lib/doctor-install-switch/scenario.sh";
 const PACKAGE_COMPAT_PATH = "scripts/e2e/lib/package-compat.mjs";
@@ -1077,6 +1078,17 @@ grep -qx -- "OPENCLAW_E2E_COMMAND_TIMEOUT=23s" "$TMPDIR/package-args"
     expect(runner).toContain('docker_e2e_run_with_harness \\\n  "${DOCKER_ENV_ARGS[@]}"');
   });
 
+  it("cleans plugin lifecycle matrix temp roots on exit", () => {
+    const sweep = readFileSync(PLUGIN_LIFECYCLE_MATRIX_SWEEP_PATH, "utf8");
+
+    expect(sweep).toContain("cleanup() {");
+    expect(sweep).toContain("openclaw_plugins_cleanup_fixture_servers");
+    expect(sweep).toContain('rm -rf "$resource_dir"');
+    expect(sweep).toContain('rm -rf "$pack_root"');
+    expect(sweep).toContain('rm -rf "$registry_root"');
+    expect(sweep.match(/trap cleanup EXIT/g)).toHaveLength(2);
+  });
+
   it("wraps direct Docker E2E npm installs with the shared timeout helper", () => {
     const multiNode = readFileSync(MULTI_NODE_UPDATE_DOCKER_E2E_PATH, "utf8");
     const updateChannel = readFileSync(UPDATE_CHANNEL_SWITCH_DOCKER_E2E_PATH, "utf8");
