fix(memory-lancedb): centralize cli integer parsing

steipete · steipete · commit ba2620a9afa9 · 2026-05-29T06:24:22.000-04:00
diff --git a/extensions/memory-lancedb/index.test.ts b/extensions/memory-lancedb/index.test.ts
@@ -11,6 +11,7 @@
 import { Buffer } from "node:buffer";
 import fs from "node:fs/promises";
 import path from "node:path";
+import { Command } from "commander";
 import {
   clearMemoryPluginState,
   getMemoryCapabilityRegistration,
@@ -708,6 +709,73 @@ describe("memory plugin e2e", () => {
     });
   });
 
+  test("normalizes signed decimal CLI limits through the shared parser", async () => {
+    const ensureGlobalUndiciEnvProxyDispatcher = vi.fn();
+    const toArray = vi.fn(async () => []);
+    const limit = vi.fn(() => ({ toArray }));
+    const select = vi.fn(() => ({ limit, toArray }));
+    const query = vi.fn(() => ({ select }));
+    const loadLanceDbModule = vi.fn(async () => ({
+      connect: vi.fn(async () => ({
+        tableNames: vi.fn(async () => ["memories"]),
+        openTable: vi.fn(async () => ({
+          query,
+          countRows: vi.fn(async () => 0),
+          add: vi.fn(async () => undefined),
+          delete: vi.fn(async () => undefined),
+        })),
+      })),
+    }));
+
+    await withMockedOpenAiMemoryPlugin({
+      ensureGlobalUndiciEnvProxyDispatcher,
+      loadLanceDbModule,
+      run: async (dynamicMemoryPlugin) => {
+        const registerCli = vi.fn();
+        const mockApi = {
+          id: "memory-lancedb",
+          name: "Memory (LanceDB)",
+          source: "test",
+          config: {},
+          pluginConfig: {
+            embedding: {
+              apiKey: OPENAI_API_KEY,
+              model: "text-embedding-3-small",
+            },
+            dbPath: getDbPath(),
+            autoCapture: false,
+            autoRecall: false,
+          },
+          runtime: {},
+          logger: {
+            info: vi.fn(),
+            warn: vi.fn(),
+            error: vi.fn(),
+            debug: vi.fn(),
+          },
+          registerTool: vi.fn(),
+          registerCli,
+          registerService: vi.fn(),
+          on: vi.fn(),
+          resolvePath: (filePath: string) => filePath,
+        };
+        const log = vi.spyOn(console, "log").mockImplementation(() => undefined);
+        try {
+          dynamicMemoryPlugin.register(mockApi as any);
+          const registrar = firstMockArg(registerCli as unknown as MockCallSource, "cli registrar");
+          const program = new Command();
+          (registrar as (params: { program: Command }) => void)({ program });
+
+          await program.parseAsync(["node", "openclaw", "ltm", "list", "--limit", "+03"]);
+
+          expect(limit).toHaveBeenCalledWith(3);
+        } finally {
+          log.mockRestore();
+        }
+      },
+    });
+  });
+
   test("keeps before_prompt_build registered but inert when auto-recall is disabled", async () => {
     const on = vi.fn();
     const mockApi = {
diff --git a/extensions/memory-lancedb/index.ts b/extensions/memory-lancedb/index.ts
@@ -15,6 +15,7 @@ import {
 } from "openclaw/plugin-sdk/channel-actions";
 import type { OpenClawConfig } from "openclaw/plugin-sdk/config-contracts";
 import type { MemoryEmbeddingProvider } from "openclaw/plugin-sdk/memory-core-host-engine-embeddings";
+import { parseStrictPositiveInteger } from "openclaw/plugin-sdk/number-runtime";
 import { readFiniteNumberParam, readPositiveIntegerParam } from "openclaw/plugin-sdk/param-readers";
 import { resolveLivePluginConfigObject } from "openclaw/plugin-sdk/plugin-config-runtime";
 import { ensureGlobalUndiciEnvProxyDispatcher } from "openclaw/plugin-sdk/runtime-env";
@@ -196,8 +197,8 @@ function parsePositiveIntegerOption(value: string | undefined, flag: string): nu
   if (value === undefined) {
     return undefined;
   }
-  const parsed = Number(value);
-  if (!Number.isInteger(parsed) || parsed < 1) {
+  const parsed = parseStrictPositiveInteger(value);
+  if (parsed === undefined) {
     throw new Error(`${flag} must be a positive integer`);
   }
   return parsed;
