fix: satisfy room-event strict smoke types

steipete · steipete · commit b8c5a7989caf · 2026-05-15T21:12:07.000+01:00
diff --git a/src/auto-reply/reply/agent-runner-execution.ts b/src/auto-reply/reply/agent-runner-execution.ts
@@ -1622,19 +1622,23 @@ export async function runAgentTurnWithFallback(params: {
                   abortSignal: params.replyOperation?.abortSignal ?? params.opts?.abortSignal,
                   replyOperation: params.replyOperation,
                 });
-                const result = isRoomEventCliTurn
-                  ? {
-                      ...rawResult,
-                      meta: {
-                        ...rawResult.meta,
-                        agentMeta: {
-                          ...rawResult.meta?.agentMeta,
-                          sessionId: "",
-                          cliSessionBinding: undefined,
-                        },
-                      },
-                    }
-                  : rawResult;
+                const result: EmbeddedAgentRunResult =
+                  isRoomEventCliTurn && rawResult.meta.agentMeta
+                    ? (() => {
+                        const { cliSessionBinding: _cliSessionBinding, ...agentMeta } =
+                          rawResult.meta.agentMeta;
+                        return {
+                          ...rawResult,
+                          meta: {
+                            ...rawResult.meta,
+                            agentMeta: {
+                              ...agentMeta,
+                              sessionId: "",
+                            },
+                          },
+                        };
+                      })()
+                    : rawResult;
                 bootstrapPromptWarningSignaturesSeen = resolveBootstrapWarningSignaturesSeen(
                   result.meta?.systemPromptReport,
                 );
diff --git a/src/auto-reply/reply/queue/drain.ts b/src/auto-reply/reply/queue/drain.ts
@@ -232,6 +232,7 @@ function collectSummaryRuntimeMetadata(items: FollowupRun[]): FollowupRuntimeMet
 }
 
 function clearFollowupQueueSummaryState(queue: {
+  dropPolicy: "summarize" | "old" | "new";
   droppedCount: number;
   summaryLines: string[];
   summarySources?: FollowupRun[];
diff --git a/src/channels/turn/kind.ts b/src/channels/turn/kind.ts
@@ -1 +1 @@
-export type { InboundTurnKind } from "./types.js";
+export type InboundTurnKind = "user_request" | "room_event";
diff --git a/src/channels/turn/types.ts b/src/channels/turn/types.ts
@@ -21,6 +21,8 @@ import type { InboundLastRouteUpdate, RecordInboundSession } from "../session.ty
 import type { ChannelBotLoopProtectionFacts } from "./bot-loop-protection.js";
 import type { InboundTurnKind } from "./kind.js";
 
+export type { InboundTurnKind } from "./kind.js";
+
 export type ChannelTurnAdmission =
   | { kind: "dispatch"; reason?: string }
   | { kind: "observeOnly"; reason: string }

Original file line number	Diff line number	Diff line change
`@@ -232,6 +232,7 @@ function collectSummaryRuntimeMetadata(items: FollowupRun[]): FollowupRuntimeMet`
`232`	`232`	`}`
`233`	`233`
`234`	`234`	`function clearFollowupQueueSummaryState(queue: {`
	`235`	`+ dropPolicy: "summarize" \| "old" \| "new";`
`235`	`236`	`droppedCount: number;`
`236`	`237`	`summaryLines: string[];`
`237`	`238`	`summarySources?: FollowupRun[];`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-export type { InboundTurnKind } from "./types.js";`
	`1`	`+export type InboundTurnKind = "user_request" \| "room_event";`