fix(cron): no-deliver cron runs prefer final assistant text for recovery

openperf · openperf · commit b83756ddd7b9 · 2026-06-05T21:27:05.000+08:00
When deliveryPlan.mode is "none" and no channel is resolved, resolveCronChannelOutputPolicy returned preferFinalAssistantVisibleText: false. That blocked hasRecoveredToolWarning and shouldUseFinalAssistantVisibleText in resolveCronPayloadOutcome (both gates require true), so a cron run that produced valid final assistant text after only non-fatal tool warnings was still marked as a fatal error. With no channel there is no structured delivery target; the final assistant text is the only meaningful output. Returning true lets the recovery path work correctly for --no-deliver runs. Fixes #90664
diff --git a/src/cron/isolated-agent/channel-output-policy.test.ts b/src/cron/isolated-agent/channel-output-policy.test.ts
@@ -36,6 +36,13 @@ describe("cron channel output policy", () => {
     channelPluginMocks.getChannelPlugin.mockClear();
   });
 
+  it("prefers final assistant text when no channel is resolved", async () => {
+    await expect(resolveCronChannelOutputPolicy(undefined)).resolves.toEqual({
+      preferFinalAssistantVisibleText: true,
+    });
+    expect(channelPluginMocks.getChannelPlugin).not.toHaveBeenCalled();
+  });
+
   it("reads final visible text preference from the channel plugin", async () => {
     await expect(resolveCronChannelOutputPolicy("topicchat")).resolves.toEqual({
       preferFinalAssistantVisibleText: true,
diff --git a/src/cron/isolated-agent/channel-output-policy.ts b/src/cron/isolated-agent/channel-output-policy.ts
@@ -18,7 +18,8 @@ export async function resolveCronChannelOutputPolicy(channel: string | undefined
 }> {
   const channelId = normalizeOptionalLowercaseString(channel);
   if (!channelId) {
-    return { preferFinalAssistantVisibleText: false };
+    // No channel means no structured delivery; final assistant text is the only output.
+    return { preferFinalAssistantVisibleText: true };
   }
   const { getChannelPlugin } = await loadChannelPluginRuntime();
   return {
