fix(embedded-agent): treat stale thinking-block signature as replay-invalid

0xghost42 · 0xghost42 · commit b4f533eaeceb · 2026-05-29T18:43:18.000+05:30
Anthropic rejects the next call with 'Invalid signature in thinking block' once early extended-thinking signatures expire on a long session. REPLAY_INVALID_RE did not match it, so classifyProviderRuntimeFailureKind fell through and the session hard-failed instead of routing to replay recovery (strip stale thinking blocks and retry). Add the pattern so the message classifies as replay_invalid.
diff --git a/src/agents/embedded-agent-helpers/errors.test.ts b/src/agents/embedded-agent-helpers/errors.test.ts
@@ -3,7 +3,11 @@ import { beforeEach, describe, expect, it, vi } from "vitest";
 import type { OpenClawConfig } from "../../config/types.openclaw.js";
 import { MALFORMED_STREAMING_FRAGMENT_ERROR_MESSAGE } from "../../shared/assistant-error-format.js";
 import { makeAssistantMessageFixture } from "../test-helpers/assistant-message-fixtures.js";
-import { formatAssistantErrorText, isLikelyContextOverflowError } from "./errors.js";
+import {
+  classifyProviderRuntimeFailureKind,
+  formatAssistantErrorText,
+  isLikelyContextOverflowError,
+} from "./errors.js";
 
 const { toolPolicyAuditInfo } = vi.hoisted(() => ({
   toolPolicyAuditInfo: vi.fn(),
@@ -102,3 +106,18 @@ describe("isLikelyContextOverflowError", () => {
     ).toBe(true);
   });
 });
+
+describe("classifyProviderRuntimeFailureKind replay-invalid", () => {
+  it("classifies Anthropic stale thinking-block signatures as replay_invalid", () => {
+    // Expired extended-thinking signatures must route to replay recovery
+    // (strip stale thinking blocks and retry), not a hard session failure.
+    expect(classifyProviderRuntimeFailureKind("Invalid signature in thinking block")).toBe(
+      "replay_invalid",
+    );
+    expect(
+      classifyProviderRuntimeFailureKind(
+        "messages.3.content.0: Invalid signature in thinking block at index 0",
+      ),
+    ).toBe("replay_invalid");
+  });
+});
diff --git a/src/agents/embedded-agent-helpers/errors.ts b/src/agents/embedded-agent-helpers/errors.ts
@@ -353,7 +353,7 @@ const DNS_ERROR_RE = /\benotfound\b|\beai_again\b|\bgetaddrinfo\b|\bno such host
 const INTERRUPTED_NETWORK_ERROR_RE =
   /\beconnrefused\b|\beconnreset\b|\beconnaborted\b|\benetreset\b|\behostunreach\b|\behostdown\b|\benetunreach\b|\bepipe\b|\bsocket hang up\b|\bconnection refused\b|\bconnection reset\b|\bconnection aborted\b|\bnetwork is unreachable\b|\bhost is unreachable\b|\bfetch failed\b|\bconnection error\b|\bnetwork request failed\b/i;
 const REPLAY_INVALID_RE =
-  /\bprevious_response_id\b.*\b(?:invalid|unknown|not found|does not exist|expired|mismatch)\b|\btool_(?:use|call)\.(?:input|arguments)\b.*\b(?:missing|required)\b|\bincorrect role information\b|\broles must alternate\b|\binput item id does not belong to this connection\b/i;
+  /\bprevious_response_id\b.*\b(?:invalid|unknown|not found|does not exist|expired|mismatch)\b|\btool_(?:use|call)\.(?:input|arguments)\b.*\b(?:missing|required)\b|\bincorrect role information\b|\broles must alternate\b|\binput item id does not belong to this connection\b|\binvalid signature\b.*?\bthinking block\b/i;
 const SANDBOX_BLOCKED_RE =
   /\bapproval is required\b|\bapproval timed out\b|\bapproval was denied\b|\bblocked by sandbox\b|\bsandbox\b.*\b(?:blocked|denied|forbidden|disabled|not allowed)\b|\bexec denied\s*\(/i;
 const NO_BODY_HTTP_WRAPPER_RE =
