fix(sdk): require timeout attribution for provider errors

steipete · steipete · commit ae2c0cd47424 · 2026-05-30T01:38:11.000+01:00
diff --git a/packages/sdk/src/client.ts b/packages/sdk/src/client.ts
@@ -61,7 +61,7 @@ function runStatusFromWaitPayload(payload: unknown): RunResult["status"] {
   const pendingError = record.pendingError === true;
   const timeoutPhase =
     typeof record.timeoutPhase === "string" ? record.timeoutPhase.toLowerCase() : undefined;
-  const statusAlreadyTimeoutAttributed = status === "timeout" || status === "error";
+  const statusAlreadyTimeoutAttributed = status === "timeout" || status === "timed_out";
   const hardTimeout =
     !pendingError &&
     ((record.providerStarted === true && statusAlreadyTimeoutAttributed) ||
diff --git a/packages/sdk/src/index.test.ts b/packages/sdk/src/index.test.ts
@@ -182,6 +182,24 @@ describe("OpenClaw SDK", () => {
     expect(result.error?.message).toBe("provider request timed out");
   });
 
+  it("does not map provider-started wait errors to timed_out without timeout attribution", async () => {
+    const transport = new FakeTransport({
+      "agent.wait": {
+        status: "error",
+        runId: "run_provider_error",
+        providerStarted: true,
+        error: "provider authentication failed",
+      },
+    });
+    const oc = new OpenClaw({ transport });
+
+    const result = await oc.runs.wait("run_provider_error");
+
+    expect(result.runId).toBe("run_provider_error");
+    expect(result.status).toBe("failed");
+    expect(result.error?.message).toBe("provider authentication failed");
+  });
+
   it("does not treat successful provider-started wait snapshots as timed_out", async () => {
     const transport = new FakeTransport({
       "agent.wait": {
@@ -1150,9 +1168,31 @@ describe("OpenClaw SDK", () => {
       providerStarted: true,
     });
 
-    const hardTimeoutEnd = normalizeGatewayEvent({
+    const providerStartedError = normalizeGatewayEvent({
       event: "agent",
       seq: 8,
+      payload: {
+        runId: "run_1",
+        stream: "lifecycle",
+        ts,
+        data: {
+          phase: "error",
+          error: "provider authentication failed",
+          providerStarted: true,
+        },
+      },
+    });
+    expect(providerStartedError.type).toBe("run.failed");
+    expect(providerStartedError.runId).toBe("run_1");
+    expect(providerStartedError.data).toEqual({
+      phase: "error",
+      error: "provider authentication failed",
+      providerStarted: true,
+    });
+
+    const hardTimeoutEnd = normalizeGatewayEvent({
+      event: "agent",
+      seq: 9,
       payload: {
         runId: "run_1",
         stream: "lifecycle",
@@ -1174,7 +1214,7 @@ describe("OpenClaw SDK", () => {
 
     const providerStartedEnd = normalizeGatewayEvent({
       event: "agent",
-      seq: 9,
+      seq: 10,
       payload: {
         runId: "run_1",
         stream: "lifecycle",
diff --git a/packages/sdk/src/normalize.ts b/packages/sdk/src/normalize.ts
@@ -86,7 +86,7 @@ function normalizeAgentEventType(payload: JsonObject): OpenClawEventType {
       return normalizeLifecycleEndEventType(data);
     }
     if (phase === "error") {
-      if (hasHardTimeoutMetadata(data, true)) {
+      if (hasHardTimeoutMetadata(data, false)) {
         return "run.timed_out";
       }
       return "run.failed";

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ function normalizeAgentEventType(payload: JsonObject): OpenClawEventType {`
`86`	`86`	`return normalizeLifecycleEndEventType(data);`
`87`	`87`	`}`
`88`	`88`	`if (phase === "error") {`
`89`		`- if (hasHardTimeoutMetadata(data, true)) {`
	`89`	`+ if (hasHardTimeoutMetadata(data, false)) {`
`90`	`90`	`return "run.timed_out";`
`91`	`91`	`}`
`92`	`92`	`return "run.failed";`