addressing codex review

pgondhi987 · pgondhi987 · commit ad30017e4856 · 2026-05-06T15:15:17.000Z
diff --git a/extensions/skill-workshop/index.test.ts b/extensions/skill-workshop/index.test.ts
@@ -617,7 +617,7 @@ describe("skill-workshop", () => {
     expect(await store.list("pending")).toHaveLength(1);
   });
 
-  it("keeps explicit tool suggestions pending when pending mode receives apply true", async () => {
+  it("queues apply true suggestions in pending mode before explicit apply", async () => {
     const workspaceDir = await makeTempDir();
     const stateDir = await makeTempDir();
     let tool: AnyAgentTool | undefined;
@@ -651,18 +651,24 @@ describe("skill-workshop", () => {
     const proposalId =
       (result?.details as { proposal?: { id?: string } } | undefined)?.proposal?.id ?? "";
     expect(proposalId).toBeTruthy();
-    await expect(
-      tool?.execute?.("call-2", {
-        action: "apply",
-        id: proposalId,
-      }),
-    ).rejects.toThrow("tool apply requires auto approval policy");
     await expect(
       fs.access(path.join(workspaceDir, "skills", "screenshot-asset-workflow", "SKILL.md")),
     ).rejects.toMatchObject({ code: "ENOENT" });
     const store = new SkillWorkshopStore({ stateDir, workspaceDir });
     expect(await store.list("pending")).toHaveLength(1);
     expect(await store.list("applied")).toHaveLength(0);
+
+    const applied = await tool?.execute?.("call-2", {
+      action: "apply",
+      id: proposalId,
+    });
+
+    expect(applied?.details).toMatchObject({ status: "applied" });
+    await expect(
+      fs.access(path.join(workspaceDir, "skills", "screenshot-asset-workflow", "SKILL.md")),
+    ).resolves.toBeUndefined();
+    expect(await store.list("pending")).toHaveLength(0);
+    expect(await store.list("applied")).toHaveLength(1);
   });
 
   it("uses the reviewer to propose existing skill repairs", async () => {
diff --git a/extensions/skill-workshop/src/prompt.ts b/extensions/skill-workshop/src/prompt.ts
@@ -4,7 +4,7 @@ export function buildWorkshopGuidance(config: SkillWorkshopConfig): string {
   const writeMode =
     config.approvalPolicy === "auto"
       ? "Auto mode: apply safe workspace-skill updates; apply=false queues instead."
-      : "Pending mode: queue suggestions for review; tool calls cannot apply them.";
+      : "Pending mode: queue suggestions; use apply action after explicit approval.";
   return [
     "<skill_workshop>",
     "Use for durable procedural memory, not facts/preferences.",
diff --git a/extensions/skill-workshop/src/tool.ts b/extensions/skill-workshop/src/tool.ts
@@ -155,9 +155,6 @@ export function createSkillWorkshopTool(params: {
         return jsonResult(result);
       }
       if (action === "apply") {
-        if (params.config.approvalPolicy !== "auto") {
-          throw new Error("tool apply requires auto approval policy");
-        }
         if (!raw.id) {
           throw new Error("id required");
         }

Original file line number	Diff line number	Diff line change
`@@ -155,9 +155,6 @@ export function createSkillWorkshopTool(params: {`
`155`	`155`	`return jsonResult(result);`
`156`	`156`	`}`
`157`	`157`	`if (action === "apply") {`
`158`		`- if (params.config.approvalPolicy !== "auto") {`
`159`		`- throw new Error("tool apply requires auto approval policy");`
`160`		`- }`
`161`	`158`	`if (!raw.id) {`
`162`	`159`	`throw new Error("id required");`
`163`	`160`	`}`