fix(ui): sync tasks with missing timestamps

TurboTheTurtle · TurboTheTurtle · commit ab08180590c0 · 2026-06-03T00:45:32.000-07:00
diff --git a/ui/src/ui/controllers/workboard.test.ts b/ui/src/ui/controllers/workboard.test.ts
@@ -1799,6 +1799,41 @@ describe("workboard controller", () => {
     expect(state.cards[0]).toMatchObject({ status: "running" });
   });
 
+  it("keeps task lifecycle sync active when task timestamps are missing", async () => {
+    const host = {};
+    const state = getWorkboardState(host);
+    const linked = {
+      ...sampleCard,
+      status: "running",
+      sessionKey: sampleTaskSessionKey,
+      runId: "run-1",
+      taskId: "task-1",
+      updatedAt: 5,
+    } satisfies WorkboardCard;
+    const { updatedAt: _ignored, ...taskWithoutUpdatedAt } = sampleTask;
+    state.loaded = true;
+    state.cards = [linked];
+    state.tasksByCardId.set("card-1", sampleTask);
+    const client = createClient({
+      "tasks.list": { tasks: [{ ...taskWithoutUpdatedAt, status: "completed" }] },
+      "workboard.cards.update": {
+        card: { ...linked, status: "review", updatedAt: 6 },
+      },
+    });
+
+    await syncWorkboardLifecycle({
+      host,
+      client: client as never,
+      sessions: [],
+    });
+
+    expect(client.request).toHaveBeenNthCalledWith(2, "workboard.cards.update", {
+      id: "card-1",
+      patch: { status: "review" },
+    });
+    expect(state.cards[0]).toMatchObject({ status: "review" });
+  });
+
   it("applies fresh failed task lifecycle sync after a newer task update", async () => {
     const host = {};
     const state = getWorkboardState(host);
diff --git a/ui/src/ui/controllers/workboard.ts b/ui/src/ui/controllers/workboard.ts
@@ -1007,6 +1007,11 @@ function sessionUpdatedAtValue(session: GatewaySessionRow): number | undefined {
   return typeof session.updatedAt === "number" ? session.updatedAt : undefined;
 }
 
+function taskLifecycleSourceUpdatedAt(task: WorkboardTaskSummary): number | undefined {
+  const updatedAt = taskUpdatedAtValue(task);
+  return updatedAt > 0 ? updatedAt : undefined;
+}
+
 function taskSessionKeyMatchesCardSession(
   cardSessionKey: string,
   taskSessionKey: string | undefined,
@@ -1251,14 +1256,14 @@ export function getWorkboardLifecycle(
           session,
           state: "running",
           targetStatus: "running",
-          sourceUpdatedAt: taskUpdatedAtValue(task),
+          sourceUpdatedAt: taskLifecycleSourceUpdatedAt(task),
         };
       case "completed":
         return {
           session,
           state: "succeeded",
           targetStatus: "review",
-          sourceUpdatedAt: taskUpdatedAtValue(task),
+          sourceUpdatedAt: taskLifecycleSourceUpdatedAt(task),
         };
       case "failed":
       case "cancelled":
@@ -1267,7 +1272,7 @@ export function getWorkboardLifecycle(
           session,
           state: "failed",
           targetStatus: "blocked",
-          sourceUpdatedAt: taskUpdatedAtValue(task),
+          sourceUpdatedAt: taskLifecycleSourceUpdatedAt(task),
         };
     }
   }
@@ -1329,6 +1334,7 @@ function shouldSkipStaleLifecycleStatusSync(card: WorkboardCard, lifecycle: Work
   return (
     Boolean(lifecycle.targetStatus) &&
     typeof lifecycle.sourceUpdatedAt === "number" &&
+    lifecycle.sourceUpdatedAt > 0 &&
     lifecycle.sourceUpdatedAt < card.updatedAt
   );
 }
