fix(feishu): wire setup runtime setter (#89814)

clawsweeper[bot] · glenn-agent · Takhoffman · web-flow · commit a61c94b1f179 · 2026-06-03T12:36:42.000Z
Summary: - The PR adds a narrow Feishu runtime-setter entrypoint, wires it into the Feishu setup entry, and adds regression coverage for setup-only runtime registration. - PR surface: Source +7, Tests +22. Total +29 across 4 files. - Reproducibility: yes. source inspection gives a high-confidence reproduction path: current Feishu setup-only ... ate when that setter is present. I did not run a live Feishu tenant message repro in this read-only review. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(feishu): wire setup runtime setter Validation: - ClawSweeper review passed for head befd074. - Required merge gates passed before the squash merge. Prepared head SHA: befd074 Review: #89814 (comment) Co-authored-by: Glenn-Agent <glenn_agent@163.com> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <781889+takhoffman@users.noreply.github.com>
diff --git a/extensions/feishu/runtime-setter-api.ts b/extensions/feishu/runtime-setter-api.ts
@@ -0,0 +1,3 @@
+// Narrow entry point for setFeishuRuntime. Keep setup/runtime registration
+// from pulling in the broader Feishu runtime-api barrel.
+export { setFeishuRuntime } from "./src/runtime.js";
diff --git a/extensions/feishu/setup-entry.test.ts b/extensions/feishu/setup-entry.test.ts
@@ -17,5 +17,16 @@ describe("feishu setup entry", () => {
     expect(setupEntry.features).toEqual({ legacyStateMigrations: true });
     expect(typeof setupEntry.loadSetupPlugin).toBe("function");
     expect(setupEntry.loadLegacyStateMigrationDetector?.()).toBeTypeOf("function");
+    expect(typeof setupEntry.setChannelRuntime).toBe("function");
+  });
+
+  it("wires the Feishu runtime from setup-only registration", async () => {
+    const { default: setupEntry } = await import("./setup-entry.js");
+    const runtime = { channel: { inbound: { run: vi.fn() } } };
+
+    setupEntry.setChannelRuntime?.(runtime as never);
+
+    const { getFeishuRuntime } = await import("./src/runtime.js");
+    expect(getFeishuRuntime()).toBe(runtime);
   });
 });
diff --git a/extensions/feishu/setup-entry.ts b/extensions/feishu/setup-entry.ts
@@ -17,4 +17,8 @@ export default defineBundledChannelSetupEntry({
     specifier: "./secret-contract-api.js",
     exportName: "channelSecrets",
   },
+  runtime: {
+    specifier: "./runtime-setter-api.js",
+    exportName: "setFeishuRuntime",
+  },
 });
diff --git a/src/plugins/contracts/plugin-sdk-runtime-api-guardrails.test.ts b/src/plugins/contracts/plugin-sdk-runtime-api-guardrails.test.ts
@@ -381,4 +381,15 @@ describe("runtime api guardrails", () => {
       'export { setMatrixRuntime } from "./src/runtime.js";',
     ]);
   });
+
+  it("keeps Feishu's narrow runtime-setter entrypoint pinned to a single export", () => {
+    const setterFile = bundledPluginFile({
+      rootDir: ROOT_DIR,
+      pluginId: "feishu",
+      relativePath: "runtime-setter-api.ts",
+    });
+    expect(readExportStatements(setterFile)).toEqual([
+      'export { setFeishuRuntime } from "./src/runtime.js";',
+    ]);
+  });
 });

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+// Narrow entry point for setFeishuRuntime. Keep setup/runtime registration`
	`2`	`+// from pulling in the broader Feishu runtime-api barrel.`
	`3`	`+export { setFeishuRuntime } from "./src/runtime.js";`