fix(matrix): respect is_direct: false in isStrictDirectRoom

JulyanXu · JulyanXu · commit a5ed4e50ac08 · 2026-05-22T10:02:29.000+08:00
isStrictDirectRoom returned evidence.strict directly without considering memberStateFlag. When a 2-person room has is_direct: false on the membership event, the function still classified it as a strict DM, causing requireMention to be silently bypassed for rooms configured under groups[]. Now checks memberStateFlag === false before returning true, ensuring explicit is_direct: false signals override the 2-member heuristic. Closes #85017
diff --git a/extensions/matrix/src/matrix/direct-room.ts b/extensions/matrix/src/matrix/direct-room.ts
@@ -117,12 +117,13 @@ export async function isStrictDirectRoom(params: {
   remoteUserId: string;
   selfUserId?: string | null;
 }): Promise<boolean> {
-  return (
-    await inspectMatrixDirectRoomEvidence({
-      client: params.client,
-      roomId: params.roomId,
-      remoteUserId: params.remoteUserId,
-      selfUserId: params.selfUserId,
-    })
-  ).strict;
+  const evidence = await inspectMatrixDirectRoomEvidence({
+    client: params.client,
+    roomId: params.roomId,
+    remoteUserId: params.remoteUserId,
+    selfUserId: params.selfUserId,
+  });
+  if (!evidence.strict) return false;
+  if (evidence.memberStateFlag === false) return false;
+  return true;
 }
