fix(memory-wiki): make wiki lint tool output path-safe

LLagoon3 · clawsweeper[bot] · commit a4b9a29ecdc2 · 2026-05-18T16:24:51.000Z
diff --git a/extensions/memory-wiki/src/tool.test.ts b/extensions/memory-wiki/src/tool.test.ts
@@ -1,6 +1,10 @@
+import fs from "node:fs/promises";
+import path from "node:path";
 import { describe, expect, it } from "vitest";
 import type { ResolvedMemoryWikiConfig } from "./config.js";
-import { createWikiApplyTool } from "./tool.js";
+import { createWikiApplyTool, createWikiLintTool } from "./tool.js";
+import { lintMemoryWikiVault } from "./lint.js";
+import { createMemoryWikiTestHarness } from "./test-helpers.js";
 
 function asSchemaObject(value: unknown): Record<string, unknown> {
   if (typeof value !== "object" || value === null || Array.isArray(value)) {
@@ -10,6 +14,8 @@ function asSchemaObject(value: unknown): Record<string, unknown> {
 }
 
 describe("memory-wiki tools", () => {
+  const harness = createMemoryWikiTestHarness();
+
   it("allows provenance metadata in wiki_apply claim evidence", () => {
     const tool = createWikiApplyTool({} as ResolvedMemoryWikiConfig);
     const applyProperties = asSchemaObject(asSchemaObject(tool.parameters).properties);
@@ -33,4 +39,40 @@ describe("memory-wiki tools", () => {
     ]);
     expect(evidenceProperties.confidence).toEqual({ type: "number", minimum: 0, maximum: 1 });
   });
+
+  it("returns tool-safe relative report paths from wiki_lint", async () => {
+    const { rootDir, config } = await harness.createVault({ initialize: true });
+    await fs.mkdir(path.join(rootDir, "syntheses"), { recursive: true });
+    await fs.writeFile(
+      path.join(rootDir, "syntheses", "bad.md"),
+      [
+        "---",
+        "id: synth-bad",
+        "pageType: synthesis",
+        "title: Bad Page",
+        "---",
+        "",
+        "This links to [[Missing Page]].",
+      ].join("\n"),
+      "utf8",
+    );
+
+    const tool = createWikiLintTool(config);
+    const result = await tool.execute("lint-call", {});
+    const text = result.content.find((part) => part.type === "text")?.text ?? "";
+    const details = asSchemaObject(result.details);
+
+    expect(text).toContain("Report: reports/lint.md");
+    expect(text).not.toContain(rootDir);
+    expect(details.reportPath).toBe("reports/lint.md");
+    expect(details).not.toHaveProperty("vaultRoot");
+    expect(JSON.stringify(details)).not.toContain(rootDir);
+    expect(asSchemaObject(details.issuesByCategory).links).toEqual(
+      expect.arrayContaining([expect.objectContaining({ code: "broken-wikilink" })]),
+    );
+
+    const lintResult = await lintMemoryWikiVault(config);
+    expect(path.isAbsolute(lintResult.reportPath)).toBe(true);
+    expect(lintResult.reportPath).toContain(rootDir);
+  });
 });
diff --git a/extensions/memory-wiki/src/tool.ts b/extensions/memory-wiki/src/tool.ts
@@ -1,3 +1,4 @@
+import path from "node:path";
 import { Type } from "typebox";
 import type { AnyAgentTool, OpenClawConfig } from "../api.js";
 import { applyMemoryWikiMutation, normalizeMemoryWikiMutationInput } from "./apply.js";
@@ -11,6 +12,20 @@ import { getMemoryWikiPage, searchMemoryWiki, WIKI_SEARCH_MODES } from "./query.
 import { syncMemoryWikiImportedSources } from "./source-sync.js";
 import { renderMemoryWikiStatus, resolveMemoryWikiStatus } from "./status.js";
 
+function formatWikiToolReportPath(config: ResolvedMemoryWikiConfig, reportPath: string): string {
+  const vaultRoot = path.resolve(config.vault.path);
+  const resolvedReportPath = path.resolve(reportPath);
+  const relativeReportPath = path.relative(vaultRoot, resolvedReportPath);
+  if (
+    !relativeReportPath ||
+    relativeReportPath.startsWith("..") ||
+    path.isAbsolute(relativeReportPath)
+  ) {
+    return reportPath;
+  }
+  return relativeReportPath.replace(/\\/g, "/");
+}
+
 const WikiStatusSchema = Type.Object({}, { additionalProperties: false });
 const WikiLintSchema = Type.Object({}, { additionalProperties: false });
 const WikiSearchBackendSchema = Type.Union(
@@ -182,6 +197,7 @@ export function createWikiLintTool(
       const provenance = result.issuesByCategory.provenance.length;
       const errors = result.issues.filter((issue) => issue.severity === "error").length;
       const warnings = result.issues.filter((issue) => issue.severity === "warning").length;
+      const reportPath = formatWikiToolReportPath(config, result.reportPath);
       const summary =
         result.issueCount === 0
           ? "No wiki lint issues."
@@ -190,11 +206,16 @@ export function createWikiLintTool(
               `Contradictions: ${contradictions}`,
               `Open questions: ${openQuestions}`,
               `Provenance gaps: ${provenance}`,
-              `Report: ${result.reportPath}`,
+              `Report: ${reportPath}`,
             ].join("\n");
       return {
         content: [{ type: "text", text: summary }],
-        details: result,
+        details: {
+          issueCount: result.issueCount,
+          issues: result.issues,
+          issuesByCategory: result.issuesByCategory,
+          reportPath,
+        },
       };
     },
   };
