fix(ui): disable chat refresh button during active agent turn

Angfr95 · Angfr95 · commit 9f537a94620c · 2026-04-26T07:23:30.000+02:00
The refresh button was only guarded by chatLoading and connected state, allowing clicks during active agent turns. This could stall the run, reset chat state, and wedge the gateway. Add chatSending, chatRunId, and chatStream guards to match the existing busy-state pattern used by the model and thinking selects. Fixes #65522
diff --git a/extensions/slack/src/monitor/provider.gateway-crash.test.ts b/extensions/slack/src/monitor/provider.gateway-crash.test.ts
@@ -1,24 +1,28 @@
-import { describe, it, expect, vi } from "vitest";
-import { monitorSlackProvider } from "./provider.js";
+import { describe, expect, it, vi } from "vitest";
 
 vi.mock("@slack/bolt", () => {
+  class SocketModeReceiver {
+    requestListener = vi.fn();
+  }
+  class HTTPReceiver {
+    requestListener = vi.fn();
+  }
   class App {
-    client = {
-      auth: {
-        test: vi.fn().mockResolvedValue({ user_id: "U123", team_id: "T123", api_app_id: "A123" }),
-      },
-    };
-    start = vi.fn().mockRejectedValue(new Error("An API error occurred: account_inactive"));
-    stop = vi.fn().mockResolvedValue(undefined);
+    receiver: unknown;
+    constructor(opts: { receiver?: unknown } = {}) {
+      this.receiver = opts.receiver;
+    }
+    use = vi.fn();
     event = vi.fn();
     message = vi.fn();
     action = vi.fn();
     shortcut = vi.fn();
     command = vi.fn();
     error = vi.fn();
+    start = vi.fn().mockRejectedValue(new Error("An API error occurred: account_inactive"));
+    stop = vi.fn().mockResolvedValue(undefined);
   }
-  class HTTPReceiver {requestListener = vi.fn();}
-  return { default: App, App, HTTPReceiver };
+  return { default: App, App, HTTPReceiver, SocketModeReceiver };
 });
 
 vi.mock("../accounts.js", () => ({
@@ -31,6 +35,12 @@ vi.mock("../accounts.js", () => ({
   }),
 }));
 
+vi.mock("../client.js", () => ({
+  resolveSlackWebClientOptions: vi.fn().mockReturnValue({}),
+}));
+
+import { monitorSlackProvider } from "./provider.js";
+
 describe("monitorSlackProvider - gateway crash prevention", () => {
   it("resolves instead of rejecting on non-recoverable auth error", async () => {
     await expect(
diff --git a/ui/src/ui/app-render.helpers.ts b/ui/src/ui/app-render.helpers.ts
@@ -237,7 +237,7 @@ export function renderChatControls(state: AppViewState) {
     <div class="chat-controls">
       <button
         class="btn btn--sm btn--icon"
-        ?disabled=${state.chatLoading || !state.connected}
+        ?disabled=${state.chatLoading || !state.connected || state.chatSending || Boolean(state.chatRunId) || state.chatStream !== null}
         @click=${async () => {
           const app = state as unknown as ChatRefreshHost;
           app.chatManualRefreshInFlight = true;
