fix(agent): allow media retry after blocked delivery

obviyus · obviyus · commit 9df7de082346 · 2026-05-30T00:02:06.000+05:30
diff --git a/src/agents/image-generation-task-status.test.ts b/src/agents/image-generation-task-status.test.ts
@@ -227,6 +227,49 @@ describe("image generation task status", () => {
     );
   });
 
+  it("does not use a delivery-blocked image task as a succeeded duplicate guard", () => {
+    const now = Date.now();
+    recordRecentMediaGenerationTaskStartForSession({
+      sessionKey: "agent:main",
+      taskKind: IMAGE_GENERATION_TASK_KIND,
+      sourcePrefix: "image_generate",
+      taskId: "task-blocked-delivery",
+      runId: "run-blocked-delivery",
+      taskLabel: "recent prompt",
+      requestKey: "image-request:blocked",
+      providerId: "xai",
+      progressSummary: "Generating image",
+      nowMs: now - 20_000,
+    });
+    taskRuntimeInternalMocks.listTasksForOwnerKey.mockReturnValue([
+      {
+        taskId: "task-blocked-delivery",
+        runId: "run-blocked-delivery",
+        runtime: "cli",
+        taskKind: IMAGE_GENERATION_TASK_KIND,
+        sourceId: "image_generate:xai",
+        requesterSessionKey: "agent:main",
+        ownerKey: "agent:main",
+        scopeKind: "session",
+        task: "recent prompt",
+        status: "succeeded",
+        terminalOutcome: "blocked",
+        terminalSummary: "Required completion delivery failed before reaching the requester.",
+        deliveryStatus: "not_applicable",
+        notifyPolicy: "silent",
+        createdAt: now - 20_000,
+        endedAt: now - 10_000,
+        progressSummary: "Generated 1 image",
+      },
+    ]);
+
+    expect(
+      findDuplicateGuardImageGenerationTaskForSession("agent:main", {
+        requestKey: "image-request:blocked",
+      }),
+    ).toBeUndefined();
+  });
+
   it("does not use a recent succeeded image task without a matching request key", () => {
     const now = Date.now();
     recordRecentMediaGenerationTaskStartForSession({
diff --git a/src/agents/media-generation-task-status-shared.ts b/src/agents/media-generation-task-status-shared.ts
@@ -89,6 +89,7 @@ function isTaskRecentSuccessfulDuplicate(params: {
 }): boolean {
   return (
     params.task.status === "succeeded" &&
+    params.task.terminalOutcome !== "blocked" &&
     Boolean(params.requestKey && params.cachedRequestKey === params.requestKey) &&
     isRecentMediaGenerationTaskRecord({
       task: params.task,
