fix(tui): redact tool details before middle truncation

SebTardif · SebTardif · commit 9c95df154da4 · 2026-05-30T20:41:32.000-07:00
Apply redactToolDetail() to command and generic string text before
middle truncation so credential-like suffixes are masked while full
flag/key context is still available. Previously, truncation could
remove the --flag prefix while preserving the raw secret at the tail,
causing redaction patterns to miss the value.

Add regression tests for sk- prefixed tokens in commands and ghp_
tokens in generic string details.

Signed-off-by: Sebastien Tardif &lt;sebtardif@ncf.ca&gt;
diff --git a/src/agents/tool-display-common.ts b/src/agents/tool-display-common.ts
@@ -3,6 +3,7 @@ import {
   normalizeOptionalString,
 } from "@openclaw/normalization-core/string-coerce";
 import { parseStrictFiniteNumber } from "../infra/parse-finite-number.js";
+import { redactToolDetail } from "../logging/redact.js";
 import { resolveExecDetail, type ToolDetailMode } from "./tool-display-exec.js";
 import { asRecord } from "./tool-display-record.js";
 
@@ -116,10 +117,11 @@ function coerceDisplayValue(
     if (!trimmed) {
       return undefined;
     }
-    const firstLine = normalizeOptionalString(trimmed.split(/\r?\n/)[0]) ?? "";
-    if (!firstLine) {
+    const rawLine = normalizeOptionalString(trimmed.split(/\r?\n/)[0]) ?? "";
+    if (!rawLine) {
       return undefined;
     }
+    const firstLine = redactToolDetail(rawLine);
     if (firstLine.length > maxStringChars) {
       const half = Math.floor((maxStringChars - 1) / 2);
       return `${firstLine.slice(0, half)}…${firstLine.slice(-(maxStringChars - 1 - half))}`;
diff --git a/src/agents/tool-display-exec.ts b/src/agents/tool-display-exec.ts
@@ -1,3 +1,4 @@
+import { redactToolDetail } from "../logging/redact.js";
 import {
   binaryName,
   firstPositional,
@@ -426,10 +427,12 @@ function isGenericSummary(summary: string): boolean {
 }
 
 function compactRawCommand(raw: string, maxLength = 120): string {
-  const oneLine = raw
-    .replace(/\s*\n\s*/g, " ")
-    .replace(/\s{2,}/g, " ")
-    .trim();
+  const oneLine = redactToolDetail(
+    raw
+      .replace(/\s*\n\s*/g, " ")
+      .replace(/\s{2,}/g, " ")
+      .trim(),
+  );
   if (oneLine.length <= maxLength) {
     return oneLine;
   }
diff --git a/src/agents/tool-display.test.ts b/src/agents/tool-display.test.ts
@@ -521,6 +521,17 @@ describe("compactRawCommand middle truncation", () => {
     const result = resolveExecDetail({ command: "/opt/custom/bin/my-tool --version" });
     expect(result).toBe("/opt/custom/bin/my-tool --version");
   });
+
+  it("redacts credential-like tails before middle truncation", () => {
+    // The --token flag and its value sit in the middle of a long command.
+    // Without redaction-before-truncation, middle truncation could cut out
+    // the --token flag context but preserve the raw secret at the tail.
+    const longCommand =
+      "/opt/custom/bin/deploy --region us-east-1 --token sk-proj-ABCDEFGHIJKLMNOP1234567890abcdefghij --output /data/results/deploy-output.json";
+    const result = resolveExecDetail({ command: longCommand });
+    // The sk- prefixed token must be redacted (masked) before truncation
+    expect(result).not.toContain("ABCDEFGHIJKLMNOP1234567890abcdefghij");
+  });
 });
 
 describe("coerceDisplayValue middle truncation", () => {
@@ -553,4 +564,22 @@ describe("coerceDisplayValue middle truncation", () => {
     expect(detail).toBe("short-task-name");
     expect(detail).not.toContain("…");
   });
+
+  it("redacts credential-like values in long generic string details", () => {
+    // A long string whose tail contains a GitHub PAT. Without
+    // redaction-before-truncation, middle truncation could preserve
+    // the raw token at the tail after its prefix context is cut.
+    const longValue =
+      "Deploying service to production cluster with auth ghp_ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnop and " +
+      "x".repeat(200) +
+      " final-step";
+    const detail = formatToolDetail(
+      resolveToolDisplay({
+        name: "sessions_spawn",
+        args: { task: longValue },
+      }),
+    );
+    // The ghp_ token must be redacted before truncation
+    expect(detail).not.toContain("ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnop");
+  });
 });
