fix(cli): reject partial numeric options

steipete · steipete · commit 9755241b56f0 · 2026-05-27T14:36:07.000-04:00
diff --git a/src/commands/channels.add.test.ts b/src/commands/channels.add.test.ts
@@ -880,7 +880,7 @@ describe("channelsAddCommand", () => {
     expect(runtime.exit).not.toHaveBeenCalled();
   });
 
-  it("drops malformed numeric channel setup options before plugin setup", async () => {
+  it("rejects malformed numeric channel setup options before plugin setup", async () => {
     const applyAccountConfig = vi.fn(({ cfg, input }: ApplyAccountConfigParams) => ({
       ...cfg,
       channels: {
@@ -898,21 +898,19 @@ describe("channelsAddCommand", () => {
     configMocks.readConfigFileSnapshot.mockResolvedValue({ ...baseConfigSnapshot });
     setActivePluginRegistry(createTestRegistry([{ pluginId: "matrix", plugin, source: "test" }]));
 
-    await channelsAddCommand(
-      {
-        channel: "matrix",
-        initialSyncLimit: "10x",
-      },
-      runtime,
-      { hasFlags: true },
-    );
+    await expect(
+      channelsAddCommand(
+        {
+          channel: "matrix",
+          initialSyncLimit: "10x",
+        },
+        runtime,
+        { hasFlags: true },
+      ),
+    ).rejects.toThrow("--initial-sync-limit must be a non-negative integer.");
 
-    expect(applyAccountConfig).toHaveBeenCalledTimes(1);
-    expect(
-      (applyAccountConfig.mock.calls[0]?.[0] as ApplyAccountConfigParams | undefined)?.input
-        .initialSyncLimit,
-    ).toBeUndefined();
-    expect(writtenChannel("matrix").initialSyncLimit).toBeUndefined();
+    expect(applyAccountConfig).not.toHaveBeenCalled();
+    expect(configMocks.writeConfigFile).not.toHaveBeenCalled();
   });
 
   it("falls back from untrusted workspace catalog shadows when adding by alias", async () => {
diff --git a/src/commands/channels/add.ts b/src/commands/channels/add.ts
@@ -80,8 +80,15 @@ async function resolveCatalogChannelEntry(raw: string, cfg: OpenClawConfig | nul
   });
 }
 
-function parseOptionalInt(value: unknown): number | undefined {
-  return parseStrictNonNegativeInteger(value);
+function parseOptionalInt(value: unknown, flag: string): number | undefined {
+  if (value === undefined || value === null || value === "") {
+    return undefined;
+  }
+  const parsed = parseStrictNonNegativeInteger(value);
+  if (parsed === undefined) {
+    throw new Error(`${flag} must be a non-negative integer.`);
+  }
+  return parsed;
 }
 
 function parseOptionalDelimitedInput(value: unknown): string[] | undefined {
@@ -111,7 +118,7 @@ function buildChannelSetupInput(opts: ChannelsAddOptions): ChannelSetupInput {
     input.secretFile ??= readOptionalString(input.tokenFile);
   }
 
-  input.initialSyncLimit = parseOptionalInt(opts.initialSyncLimit);
+  input.initialSyncLimit = parseOptionalInt(opts.initialSyncLimit, "--initial-sync-limit");
   input.groupChannels = parseOptionalDelimitedInput(opts.groupChannels);
   input.dmAllowlist = parseOptionalDelimitedInput(opts.dmAllowlist);
   return input as ChannelSetupInput;
