fix(memory): memoryFlush fires every compaction cycle instead of every other

Kaspre · claude · Kaspre · commit 9732faa51779 · 2026-04-18T14:56:15.000-04:00
After a memoryFlush during compaction, memoryFlushCompactionCount was reassigned to the post-increment compactionCount, locking both counters to the same value. The dedup gate hasAlreadyFlushedForCurrentCompaction then saw equal values and skipped the next flush. Fix: stop reassigning memoryFlushCompactionCount to the post-increment value. The counter stays at N (pre-increment); after incrementCompactionCount, compactionCount becomes N+1. Next cycle, N !== N+1, flush fires. Closes #12590. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
diff --git a/src/auto-reply/reply/agent-runner-memory.ts b/src/auto-reply/reply/agent-runner-memory.ts
@@ -791,13 +791,13 @@ export async function runMemoryFlushIfNeeded(params: {
         return result;
       },
     });
-    let memoryFlushCompactionCount =
+    const memoryFlushCompactionCount =
       activeSessionEntry?.compactionCount ??
       (params.sessionKey ? activeSessionStore?.[params.sessionKey]?.compactionCount : 0) ??
       0;
     if (memoryCompactionCompleted) {
       const previousSessionId = activeSessionEntry?.sessionId ?? params.followupRun.run.sessionId;
-      const nextCount = await memoryDeps.incrementCompactionCount({
+      await memoryDeps.incrementCompactionCount({
         cfg: params.cfg,
         sessionEntry: activeSessionEntry,
         sessionStore: activeSessionStore,
@@ -823,9 +823,10 @@ export async function runMemoryFlushIfNeeded(params: {
           });
         }
       }
-      if (typeof nextCount === "number") {
-        memoryFlushCompactionCount = nextCount;
-      }
+      // Do NOT reassign memoryFlushCompactionCount to the post-increment value.
+      // Keeping it at the pre-increment value ensures the next compaction cycle
+      // sees different counters, allowing memoryFlush to fire every cycle
+      // instead of every other. See #12590.
     }
     if (params.storePath && params.sessionKey) {
       try {
diff --git a/src/auto-reply/reply/reply-state.test.ts b/src/auto-reply/reply/reply-state.test.ts
@@ -292,6 +292,37 @@ describe("shouldRunMemoryFlush", () => {
     ).toBe(true);
   });
 
+  it("triggers on every compaction cycle when flush records pre-increment count (#12590)", () => {
+    const params = {
+      contextWindowTokens: 100_000,
+      reserveTokensFloor: 5_000,
+      softThresholdTokens: 2_000,
+    };
+
+    // Cycle 1: compactionCount=1, no prior flush → triggers
+    expect(
+      shouldRunMemoryFlush({ entry: { totalTokens: 95_000, compactionCount: 1 }, ...params }),
+    ).toBe(true);
+
+    // After flush records compactionCount=1, compaction increments to 2.
+    // Cycle 2: compactionCount=2, memoryFlushCompactionCount=1 → triggers
+    expect(
+      shouldRunMemoryFlush({
+        entry: { totalTokens: 95_000, compactionCount: 2, memoryFlushCompactionCount: 1 },
+        ...params,
+      }),
+    ).toBe(true);
+
+    // After flush records compactionCount=2, compaction increments to 3.
+    // Cycle 3: compactionCount=3, memoryFlushCompactionCount=2 → triggers
+    expect(
+      shouldRunMemoryFlush({
+        entry: { totalTokens: 95_000, compactionCount: 3, memoryFlushCompactionCount: 2 },
+        ...params,
+      }),
+    ).toBe(true);
+  });
+
   it("ignores stale cached totals", () => {
     expect(
       shouldRunMemoryFlush({
