fix(memory-wiki): make wiki_lint report path tool-safe

ThiagoCAltoe · ThiagoCAltoe · commit 9280a677b733 · 2026-05-18T02:59:58.000-03:00
diff --git a/extensions/memory-wiki/src/tool.test.ts b/extensions/memory-wiki/src/tool.test.ts
@@ -1,6 +1,12 @@
+import fs from "node:fs/promises";
+import path from "node:path";
 import { describe, expect, it } from "vitest";
 import type { ResolvedMemoryWikiConfig } from "./config.js";
-import { createWikiApplyTool } from "./tool.js";
+import { renderWikiMarkdown } from "./markdown.js";
+import { createMemoryWikiTestHarness } from "./test-helpers.js";
+import { createWikiApplyTool, createWikiLintTool } from "./tool.js";
+
+const { createVault } = createMemoryWikiTestHarness();
 
 function asSchemaObject(value: unknown): Record<string, unknown> {
   if (typeof value !== "object" || value === null || Array.isArray(value)) {
@@ -10,6 +16,44 @@ function asSchemaObject(value: unknown): Record<string, unknown> {
 }
 
 describe("memory-wiki tools", () => {
+  it("returns relative bounded details from wiki_lint", async () => {
+    const { rootDir, config } = await createVault({
+      prefix: "memory-wiki-tool-lint-",
+      config: {
+        vault: { renderMode: "obsidian" },
+      },
+    });
+    await fs.mkdir(path.join(rootDir, "entities"), { recursive: true });
+    await fs.writeFile(
+      path.join(rootDir, "entities", "alpha.md"),
+      renderWikiMarkdown({
+        frontmatter: {
+          pageType: "entity",
+          id: "entity.alpha",
+          title: "Alpha",
+        },
+        body: "# Alpha\n\n[[missing-page]]\n",
+      }),
+      "utf8",
+    );
+
+    const tool = createWikiLintTool(config);
+    const result = await tool.execute("call-1", {});
+    const text = result.content
+      .map((entry) => (entry.type === "text" ? entry.text : ""))
+      .join("\n");
+    const details = asSchemaObject(result.details);
+
+    expect(text).toContain("Report: reports/lint.md");
+    expect(text).not.toContain(rootDir);
+    expect(details.reportPath).toBe("reports/lint.md");
+    expect(details).not.toHaveProperty("vaultRoot");
+    expect(JSON.stringify(details)).not.toContain(rootDir);
+    expect(asSchemaObject(details.issuesByCategory).links).toEqual(
+      expect.arrayContaining([expect.objectContaining({ code: "broken-wikilink" })]),
+    );
+  });
+
   it("allows provenance metadata in wiki_apply claim evidence", () => {
     const tool = createWikiApplyTool({} as ResolvedMemoryWikiConfig);
     const applyProperties = asSchemaObject(asSchemaObject(tool.parameters).properties);
diff --git a/extensions/memory-wiki/src/tool.ts b/extensions/memory-wiki/src/tool.ts
@@ -1,3 +1,4 @@
+import path from "node:path";
 import { Type } from "typebox";
 import type { AnyAgentTool, OpenClawConfig } from "../api.js";
 import { applyMemoryWikiMutation, normalizeMemoryWikiMutationInput } from "./apply.js";
@@ -92,6 +93,20 @@ type WikiToolMemoryContext = {
   sandboxed?: boolean;
 };
 
+function formatWikiToolReportPath(config: ResolvedMemoryWikiConfig, reportPath: string): string {
+  const vaultRoot = path.resolve(config.vault.path);
+  const resolvedReportPath = path.resolve(reportPath);
+  const relativeReportPath = path.relative(vaultRoot, resolvedReportPath);
+  if (
+    !relativeReportPath ||
+    relativeReportPath.startsWith("..") ||
+    path.isAbsolute(relativeReportPath)
+  ) {
+    return reportPath;
+  }
+  return relativeReportPath.replace(/\\/g, "/");
+}
+
 export function createWikiStatusTool(
   config: ResolvedMemoryWikiConfig,
   appConfig?: OpenClawConfig,
@@ -182,6 +197,7 @@ export function createWikiLintTool(
       const provenance = result.issuesByCategory.provenance.length;
       const errors = result.issues.filter((issue) => issue.severity === "error").length;
       const warnings = result.issues.filter((issue) => issue.severity === "warning").length;
+      const reportPath = formatWikiToolReportPath(config, result.reportPath);
       const summary =
         result.issueCount === 0
           ? "No wiki lint issues."
@@ -190,11 +206,16 @@ export function createWikiLintTool(
               `Contradictions: ${contradictions}`,
               `Open questions: ${openQuestions}`,
               `Provenance gaps: ${provenance}`,
-              `Report: ${result.reportPath}`,
+              `Report: ${reportPath}`,
             ].join("\n");
       return {
         content: [{ type: "text", text: summary }],
-        details: result,
+        details: {
+          issueCount: result.issueCount,
+          issues: result.issues,
+          issuesByCategory: result.issuesByCategory,
+          reportPath,
+        },
       };
     },
   };
