fix: use LRU eviction for cron schedule cache

vincentkoc · vincentkoc · commit 910255af9d78 · 2026-04-28T07:48:28.000Z
diff --git a/src/cron/schedule.test.ts b/src/cron/schedule.test.ts
@@ -4,6 +4,7 @@ import {
   clearCronScheduleCacheForTest,
   computeNextRunAtMs,
   computePreviousRunAtMs,
+  getCronScheduleCacheMaxForTest,
   getCronScheduleCacheSizeForTest,
   hasCronInCacheForTest,
 } from "./schedule.js";
@@ -147,16 +148,17 @@ describe("cron schedule", () => {
 
   it("promotes accessed entries to avoid premature LRU eviction", () => {
     const nowMs = Date.parse("2026-03-01T00:00:00.000Z");
+    const cacheMax = getCronScheduleCacheMaxForTest();
 
     // Fill cache to capacity with unique expressions.
     // i=0 → "0 0 * * *", i=1 → "1 0 * * *", ..., i=511 → "31 8 * * *"
-    for (let i = 0; i < 512; i++) {
+    for (let i = 0; i < cacheMax; i++) {
       computeNextRunAtMs(
         { kind: "cron", expr: `${i % 60} ${Math.floor(i / 60)} * * *`, tz: "UTC" },
         nowMs,
       );
     }
-    expect(getCronScheduleCacheSizeForTest()).toBe(512);
+    expect(getCronScheduleCacheSizeForTest()).toBe(cacheMax);
 
     // Entry #0 ("0 0 * * *") is the oldest by insertion order.
     // Access it so LRU promotes it (delete + re-insert at end of Map).
@@ -165,7 +167,7 @@ describe("cron schedule", () => {
     // Entry #1 ("1 0 * * *") is now the least-recently-used.
     // Insert a new entry to trigger one eviction.
     computeNextRunAtMs({ kind: "cron", expr: "0 0 1 1 *", tz: "UTC" }, nowMs);
-    expect(getCronScheduleCacheSizeForTest()).toBe(512);
+    expect(getCronScheduleCacheSizeForTest()).toBe(cacheMax);
 
     // Under LRU: entry #0 survived (was promoted), entry #1 was evicted.
     // Under FIFO: entry #0 would be evicted instead — this assertion would fail.
diff --git a/src/cron/schedule.ts b/src/cron/schedule.ts
@@ -173,6 +173,10 @@ export function getCronScheduleCacheSizeForTest(): number {
   return cronEvalCache.size;
 }
 
+export function getCronScheduleCacheMaxForTest(): number {
+  return CRON_EVAL_CACHE_MAX;
+}
+
 export function hasCronInCacheForTest(expr: string, tz: string): boolean {
   return cronEvalCache.has(`${tz}\u0000${expr}`);
 }

Original file line number	Diff line number	Diff line change
`@@ -173,6 +173,10 @@ export function getCronScheduleCacheSizeForTest(): number {`
`173`	`173`	`return cronEvalCache.size;`
`174`	`174`	`}`
`175`	`175`
	`176`	`+export function getCronScheduleCacheMaxForTest(): number {`
	`177`	`+ return CRON_EVAL_CACHE_MAX;`
	`178`	`+}`
	`179`	`+`
`176`	`180`	`export function hasCronInCacheForTest(expr: string, tz: string): boolean {`
`177`	`181`	return cronEvalCache.has(`${tz}\u0000${expr}`);
`178`	`182`	`}`