fix(telegram): tighten permanent edit error match

Lucenx9 · steipete · commit 90b8f3fba20c · 2026-04-18T19:52:31.000+01:00
diff --git a/extensions/telegram/src/bot-handlers.runtime.ts b/extensions/telegram/src/bot-handlers.runtime.ts
@@ -675,7 +675,7 @@ export const registerTelegramHandlers = ({
   }
 
   const TELEGRAM_PERMANENT_CALLBACK_EDIT_ERROR_RE =
-    /400:\s*Bad Request:\s*message to edit not found|400:\s*Bad Request:\s*there is no text in the message to edit|MESSAGE_ID_INVALID|message can't be edited/i;
+    /400:\s*Bad Request:\s*message to edit not found|400:\s*Bad Request:\s*there is no text in the message to edit|MESSAGE_ID_INVALID|400:\s*Bad Request:\s*message can't be edited/i;
 
   const isPermanentTelegramCallbackEditError = (err: unknown): boolean =>
     TELEGRAM_PERMANENT_CALLBACK_EDIT_ERROR_RE.test(String(err));
diff --git a/extensions/telegram/src/bot.create-telegram-bot.test.ts b/extensions/telegram/src/bot.create-telegram-bot.test.ts
@@ -3384,6 +3384,43 @@ describe("createTelegramBot", () => {
     expect(editMessageTextSpy).toHaveBeenCalledTimes(1);
   });
 
+  it("does not swallow unprefixed command pagination edit failures", async () => {
+    createTelegramBot({ token: "tok" });
+    const callbackHandler = getOnHandler("callback_query");
+
+    const ctx = {
+      update: { update_id: 778 },
+      callbackQuery: {
+        id: "cbq-commands-non-telegram-edit-1",
+        data: "commands_page_2:main",
+        from: { id: 9, first_name: "Ada", username: "ada_bot" },
+        message: {
+          chat: { id: 1234, type: "private" },
+          date: 1736380800,
+          message_id: 21,
+        },
+      },
+      me: { username: "openclaw_bot" },
+      getFile: async () => ({ download: async () => new Uint8Array() }),
+    };
+
+    editMessageTextSpy.mockRejectedValueOnce(new Error("message can't be edited"));
+
+    await expect(
+      runTelegramMiddlewareChain({
+        ctx,
+        finalHandler: callbackHandler,
+      }),
+    ).rejects.toThrow("message can't be edited");
+
+    await runTelegramMiddlewareChain({
+      ctx,
+      finalHandler: callbackHandler,
+    });
+
+    expect(editMessageTextSpy).toHaveBeenCalledTimes(2);
+  });
+
   it("retries command pagination callbacks after a bubbled preflight failure", async () => {
     const listSkillCommandsMock = listSkillCommandsForAgents as unknown as ReturnType<typeof vi.fn>;
     listSkillCommandsMock.mockClear();

Original file line number	Diff line number	Diff line change
`@@ -675,7 +675,7 @@ export const registerTelegramHandlers = ({`
`675`	`675`	`}`
`676`	`676`
`677`	`677`	`const TELEGRAM_PERMANENT_CALLBACK_EDIT_ERROR_RE =`
`678`		`- /400:\sBad Request:\smessage to edit not found\|400:\sBad Request:\sthere is no text in the message to edit\|MESSAGE_ID_INVALID\|message can't be edited/i;`
	`678`	`+ /400:\sBad Request:\smessage to edit not found\|400:\sBad Request:\sthere is no text in the message to edit\|MESSAGE_ID_INVALID\|400:\sBad Request:\smessage can't be edited/i;`
`679`	`679`
`680`	`680`	`const isPermanentTelegramCallbackEditError = (err: unknown): boolean =>`
`681`	`681`	`TELEGRAM_PERMANENT_CALLBACK_EDIT_ERROR_RE.test(String(err));`