test(cron): tighten transcript-mock typings for upstream NormalizedOutboundPayload contract

zqchris · zqchris · commit 90a0358bc230 · 2026-05-08T10:27:52.000+08:00
Upstream change tightened NormalizedOutboundPayload to require mediaUrls and
narrowed the implicit `vi.fn()` mock-call tuple to the empty argument list.
Add explicit AppendFn / ExactFn signatures to the hoisted transcript mocks so
`mock.calls[0]?.[0]` resolves to the param shape used by the test assertions,
and supply mediaUrls: [] for the synthetic best-effort onError payload.
diff --git a/src/cron/isolated-agent/delivery-dispatch.mirror-bluebubbles.test.ts b/src/cron/isolated-agent/delivery-dispatch.mirror-bluebubbles.test.ts
@@ -24,10 +24,24 @@ const sessionMetaMocks = vi.hoisted(() => ({
   ),
 }));
 
-const transcriptMocks = vi.hoisted(() => ({
-  appendAssistantMessageToSessionTranscript: vi.fn(async () => ({ ok: true, sessionFile: "x" })),
-  appendExactAssistantMessageToSessionTranscript: vi.fn(async () => ({ ok: true })),
-}));
+type TranscriptAppendArgs = {
+  agentId?: string;
+  sessionKey: string;
+  text: string;
+  idempotencyKey?: string;
+  config?: unknown;
+};
+const transcriptMocks = vi.hoisted(() => {
+  type AppendFn = (params: TranscriptAppendArgs) => Promise<{ ok: true; sessionFile: string }>;
+  type ExactFn = (params: TranscriptAppendArgs) => Promise<{ ok: true }>;
+  return {
+    appendAssistantMessageToSessionTranscript: vi.fn<AppendFn>(async () => ({
+      ok: true,
+      sessionFile: "x",
+    })),
+    appendExactAssistantMessageToSessionTranscript: vi.fn<ExactFn>(async () => ({ ok: true })),
+  };
+});
 
 // --- Module mocks (must be hoisted before imports) ---
 
@@ -417,7 +431,7 @@ describe("dispatchCronDelivery — BlueBubbles transcript mirror", () => {
     // target transcript. The mirror append is gated on cron's all-success
     // outcome (delivered === true), which best-effort partial failure breaks.
     vi.mocked(deliverOutboundPayloads).mockImplementationOnce(async (callParams) => {
-      callParams.onError?.(new Error("send failed"), { text: "skipped" });
+      callParams.onError?.(new Error("send failed"), { text: "skipped", mediaUrls: [] });
       return [{ ok: true }] as never;
     });
     const params = {
