fix(agents): keep partial auth warm cache

steipete · steipete · commit 8c3e3d4aa571 · 2026-05-27T23:13:15.000+01:00
diff --git a/src/agents/model-provider-auth.test.ts b/src/agents/model-provider-auth.test.ts
@@ -477,8 +477,9 @@ describe("prepared provider auth state", () => {
     });
   });
 
-  it("skips off-main-thread warm when plugin synthetic auth lookup is incomplete", async () => {
+  it("keeps off-main-thread warm partial when plugin synthetic auth lookup is incomplete", async () => {
     const cfg = {} as OpenClawConfig;
+    authProfilesMocks.getRuntimeAuthProfileStoreSnapshot.mockReturnValue(undefined);
     modelAuthMocks.createRuntimeProviderAuthLookup.mockReturnValueOnce({
       envApiKey: {
         aliasMap: {},
@@ -492,7 +493,27 @@ describe("prepared provider auth state", () => {
 
     await warmCurrentProviderAuthStateOffMainThread(cfg, { runWorker });
 
-    expect(runWorker).not.toHaveBeenCalled();
+    expect(runWorker).toHaveBeenCalledWith({
+      cfg,
+      runtimeAuthLookups: [
+        {
+          agentId: "default",
+          lookup: {
+            envApiKey: {
+              aliasMap: {},
+              candidateMap: {},
+              authEvidenceMap: {},
+            },
+            syntheticAuthProviderRefs: [],
+            syntheticAuthProviderRefsComplete: false,
+          },
+        },
+      ],
+      omitFalseProviderAuth: true,
+      timeoutMs: 120_000,
+      isCancelled: expect.any(Function),
+      workerUrl: undefined,
+    });
   });
 
   it("terminates the off-main-thread warm worker when cancellation fires", async () => {
diff --git a/src/agents/model-provider-auth.ts b/src/agents/model-provider-auth.ts
@@ -71,6 +71,7 @@ type ProviderAuthWarmWorkerRunner = (params: {
   cfg: OpenClawConfig;
   runtimeAuthStores?: ProviderAuthWarmRuntimeAuthStore[];
   runtimeAuthLookups?: ProviderAuthWarmRuntimeAuthLookup[];
+  omitFalseProviderAuth?: boolean;
   timeoutMs: number;
   isCancelled: () => boolean;
   workerUrl?: URL;
@@ -319,6 +320,7 @@ export async function buildCurrentProviderAuthStateSnapshot(
     isCancelled?: () => boolean;
     readOnlyAuthStore?: boolean;
     runtimeAuthLookups?: ReadonlyMap<string, RuntimeProviderAuthLookup>;
+    omitFalseProviderAuth?: boolean;
   } = {},
 ): Promise<ProviderAuthWarmSnapshot> {
   const isWarmStale = () => options.isCancelled?.() === true;
@@ -380,11 +382,12 @@ export async function buildCurrentProviderAuthStateSnapshot(
       });
       if (
         !value &&
-        shouldOmitFalsePreparedAuthForProcessSyntheticProvider({
-          cfg,
-          provider,
-          runtimeAuthLookup,
-        })
+        (options.omitFalseProviderAuth ||
+          shouldOmitFalsePreparedAuthForProcessSyntheticProvider({
+            cfg,
+            provider,
+            runtimeAuthLookup,
+          }))
       ) {
         continue;
       }
@@ -510,27 +513,30 @@ function collectProviderAuthWarmRuntimeAuthStores(
   return entries;
 }
 
-function collectProviderAuthWarmRuntimeAuthLookups(
-  cfg: OpenClawConfig,
-): ProviderAuthWarmRuntimeAuthLookup[] | null {
+function collectProviderAuthWarmRuntimeAuthLookups(cfg: OpenClawConfig): {
+  entries: ProviderAuthWarmRuntimeAuthLookup[];
+  omitFalseProviderAuth: boolean;
+} {
   const entries: ProviderAuthWarmRuntimeAuthLookup[] = [];
+  let omitFalseProviderAuth = false;
   for (const agentId of listAgentIds(cfg)) {
     const lookup = createRuntimeProviderAuthLookup({
       cfg,
       workspaceDir: resolveAgentWorkspaceDir(cfg, agentId),
     });
     if (lookup.syntheticAuthProviderRefsComplete === false) {
-      return null;
+      omitFalseProviderAuth = true;
     }
     entries.push({ agentId, lookup });
   }
-  return entries;
+  return { entries, omitFalseProviderAuth };
 }
 
 function runProviderAuthWarmWorker(params: {
   cfg: OpenClawConfig;
   runtimeAuthStores?: ProviderAuthWarmRuntimeAuthStore[];
   runtimeAuthLookups?: ProviderAuthWarmRuntimeAuthLookup[];
+  omitFalseProviderAuth?: boolean;
   timeoutMs: number;
   isCancelled: () => boolean;
   workerUrl?: URL;
@@ -542,6 +548,7 @@ function runProviderAuthWarmWorker(params: {
       ...(params.runtimeAuthLookups?.length
         ? { runtimeAuthLookups: params.runtimeAuthLookups }
         : {}),
+      ...(params.omitFalseProviderAuth ? { omitFalseProviderAuth: true } : {}),
     },
   });
   worker.unref?.();
@@ -651,13 +658,13 @@ export async function warmCurrentProviderAuthStateOffMainThread(
   }
   const runtimeAuthStores = collectProviderAuthWarmRuntimeAuthStores(cfg);
   const runtimeAuthLookups = collectProviderAuthWarmRuntimeAuthLookups(cfg);
-  if (runtimeAuthLookups === null) {
-    return;
-  }
   const snapshot = await (options.runWorker ?? runProviderAuthWarmWorker)({
     cfg,
     ...(runtimeAuthStores.length ? { runtimeAuthStores } : {}),
-    ...(runtimeAuthLookups.length ? { runtimeAuthLookups } : {}),
+    ...(runtimeAuthLookups.entries.length
+      ? { runtimeAuthLookups: runtimeAuthLookups.entries }
+      : {}),
+    ...(runtimeAuthLookups.omitFalseProviderAuth ? { omitFalseProviderAuth: true } : {}),
     timeoutMs: options.timeoutMs ?? PROVIDER_AUTH_WARM_WORKER_TIMEOUT_MS,
     isCancelled: isWarmStale,
     workerUrl: options.workerUrl,
diff --git a/src/agents/model-provider-auth.worker.ts b/src/agents/model-provider-auth.worker.ts
@@ -16,6 +16,7 @@ type ProviderAuthWarmWorkerInput = {
     agentId: string;
     lookup: RuntimeProviderAuthLookup;
   }>;
+  omitFalseProviderAuth?: boolean;
 };
 
 type ProviderAuthWarmWorkerResult =
@@ -36,7 +37,9 @@ function isWorkerInput(value: unknown): value is ProviderAuthWarmWorkerInput {
     (!("runtimeAuthStores" in value) ||
       Array.isArray((value as { runtimeAuthStores?: unknown }).runtimeAuthStores)) &&
     (!("runtimeAuthLookups" in value) ||
-      Array.isArray((value as { runtimeAuthLookups?: unknown }).runtimeAuthLookups))
+      Array.isArray((value as { runtimeAuthLookups?: unknown }).runtimeAuthLookups)) &&
+    (!("omitFalseProviderAuth" in value) ||
+      typeof (value as { omitFalseProviderAuth?: unknown }).omitFalseProviderAuth === "boolean")
   );
 }
 
@@ -58,6 +61,7 @@ export async function runProviderAuthWarmWorkerInput(
       runtimeAuthLookups: new Map(
         input.runtimeAuthLookups?.map(({ agentId, lookup }) => [agentId, lookup]),
       ),
+      omitFalseProviderAuth: input.omitFalseProviderAuth,
     });
     return {
       status: "ok",
