agents: use flat heartbeat tool enums

pashpashpash · pashpashpash · commit 8ba2de82692b · 2026-05-01T14:23:02.000-04:00
diff --git a/src/agents/tools/heartbeat-response-tool.test.ts b/src/agents/tools/heartbeat-response-tool.test.ts
@@ -2,7 +2,32 @@ import { describe, expect, it } from "vitest";
 import { HEARTBEAT_RESPONSE_TOOL_NAME } from "../../auto-reply/heartbeat-tool-response.js";
 import { createHeartbeatResponseTool } from "./heartbeat-response-tool.js";
 
+function readSchemaProperty(schema: unknown, key: string): Record<string, unknown> {
+  const root = schema as { properties?: Record<string, unknown> };
+  const property = root.properties?.[key];
+  expect(property).toBeTruthy();
+  return property as Record<string, unknown>;
+}
+
 describe("createHeartbeatResponseTool", () => {
+  it("uses flat enum schemas for provider portability", () => {
+    const tool = createHeartbeatResponseTool();
+
+    const outcome = readSchemaProperty(tool.parameters, "outcome");
+    const priority = readSchemaProperty(tool.parameters, "priority");
+
+    expect(outcome).toMatchObject({
+      type: "string",
+      enum: ["no_change", "progress", "done", "blocked", "needs_attention"],
+    });
+    expect(priority).toMatchObject({
+      type: "string",
+      enum: ["low", "normal", "high"],
+    });
+    expect(outcome).not.toHaveProperty("anyOf");
+    expect(priority).not.toHaveProperty("anyOf");
+  });
+
   it("records a quiet heartbeat outcome", async () => {
     const tool = createHeartbeatResponseTool();
 
diff --git a/src/agents/tools/heartbeat-response-tool.ts b/src/agents/tools/heartbeat-response-tool.ts
@@ -6,19 +6,18 @@ import {
   normalizeHeartbeatToolResponse,
 } from "../../auto-reply/heartbeat-tool-response.js";
 import { readSnakeCaseParamRaw } from "../../param-key.js";
+import { optionalStringEnum, stringEnum } from "../schema/string-enum.js";
 import type { AnyAgentTool } from "./common.js";
 import { jsonResult, ToolInputError } from "./common.js";
 
 const HeartbeatResponseToolSchema = Type.Object(
   {
-    outcome: Type.Union(HEARTBEAT_TOOL_OUTCOMES.map((value) => Type.Literal(value))),
+    outcome: stringEnum(HEARTBEAT_TOOL_OUTCOMES),
     notify: Type.Boolean(),
     summary: Type.String(),
     notificationText: Type.Optional(Type.String()),
     reason: Type.Optional(Type.String()),
-    priority: Type.Optional(
-      Type.Union(HEARTBEAT_TOOL_PRIORITIES.map((value) => Type.Literal(value))),
-    ),
+    priority: optionalStringEnum(HEARTBEAT_TOOL_PRIORITIES),
     nextCheck: Type.Optional(Type.String()),
   },
   { additionalProperties: false },
