fix(codex): emit side effects after harness rotation

Han Kim · Han Kim · commit 897656b9d017 · 2026-05-16T20:22:00.000-07:00
diff --git a/src/agents/pi-embedded-runner/compact.hooks.test.ts b/src/agents/pi-embedded-runner/compact.hooks.test.ts
@@ -1326,7 +1326,11 @@ describe("compactEmbeddedPiSession hooks (ownsCompaction engine)", () => {
     });
   });
 
-  it("rotates the active transcript after harness compaction without a delegated successor", async () => {
+  it("rotates the active transcript after harness compaction without a delegated successor and emits side effects", async () => {
+    const listener = vi.fn();
+    const cleanup = onSessionTranscriptUpdate(listener);
+    const sync = vi.fn(async () => {});
+    getMemorySearchManagerMock.mockResolvedValue({ manager: { sync } });
     maybeCompactAgentHarnessSessionMock.mockResolvedValueOnce({
       ok: true,
       compacted: true,
@@ -1344,31 +1348,46 @@ describe("compactEmbeddedPiSession hooks (ownsCompaction engine)", () => {
       leafId: "leaf-1",
     });
 
-    const result = await compactEmbeddedPiSession(
-      wrappedCompactionArgs({
-        currentTokenCount: 333,
-        config: {
-          agents: {
-            defaults: {
-              compaction: {
-                truncateAfterCompaction: true,
+    try {
+      const result = await compactEmbeddedPiSession(
+        wrappedCompactionArgs({
+          currentTokenCount: 333,
+          config: {
+            agents: {
+              defaults: {
+                compaction: {
+                  truncateAfterCompaction: true,
+                  postIndexSync: "await",
+                },
               },
             },
-          },
-        },
-      }),
-    );
+          } as never,
+        }),
+      );
 
-    expect(result.ok).toBe(true);
-    expect(result.compacted).toBe(true);
-    expect(rotateTranscriptFileAfterCompactionMock).toHaveBeenCalledWith({
-      sessionFile: TEST_SESSION_FILE,
-      synthesizeMissingBoundary: true,
-    });
-    expect(result.result?.sessionId).toBe("rotated-session");
-    expect(result.result?.sessionFile).toBe("/tmp/rotated-session.jsonl");
-    expect(result.result?.tokensBefore).toBe(333);
-    expect(result.result?.details).toEqual({ backend: "codex-app-server" });
+      expect(result.ok).toBe(true);
+      expect(result.compacted).toBe(true);
+      expect(rotateTranscriptFileAfterCompactionMock).toHaveBeenCalledWith({
+        sessionFile: TEST_SESSION_FILE,
+        synthesizeMissingBoundary: true,
+      });
+      expect(result.result?.sessionId).toBe("rotated-session");
+      expect(result.result?.sessionFile).toBe("/tmp/rotated-session.jsonl");
+      expect(result.result?.tokensBefore).toBe(333);
+      expect(result.result?.details).toEqual({ backend: "codex-app-server" });
+      expect(listener).toHaveBeenCalledTimes(1);
+      expect(listener).toHaveBeenCalledWith({
+        sessionFile: "/tmp/rotated-session.jsonl",
+        sessionKey: TEST_SESSION_KEY,
+      });
+      expect(sync).toHaveBeenCalledTimes(1);
+      expect(sync).toHaveBeenCalledWith({
+        reason: "post-compaction",
+        sessionFiles: ["/tmp/rotated-session.jsonl"],
+      });
+    } finally {
+      cleanup();
+    }
   });
 
   it("does not fire after_compaction when compaction fails", async () => {
diff --git a/src/agents/pi-embedded-runner/compact.queued.ts b/src/agents/pi-embedded-runner/compact.queued.ts
@@ -350,10 +350,16 @@ async function finalizeHarnessCompactionTranscript(params: {
     if (!rotation.rotated) {
       return result;
     }
+    const postCompactionSessionFile = rotation.sessionFile ?? params.params.sessionFile;
     log.info(
       `[compaction] rotated active transcript after harness compaction ` +
         `(sessionKey=${params.params.sessionKey ?? params.params.sessionId})`,
     );
+    await runPostCompactionSideEffects({
+      config: params.params.config,
+      sessionKey: params.params.sessionKey,
+      sessionFile: postCompactionSessionFile,
+    });
     return {
       ...result,
       result: {
@@ -367,8 +373,8 @@ async function finalizeHarnessCompactionTranscript(params: {
         ...(rotation.sessionId && rotation.sessionId !== params.params.sessionId
           ? { sessionId: rotation.sessionId }
           : {}),
-        ...(rotation.sessionFile && rotation.sessionFile !== params.params.sessionFile
-          ? { sessionFile: rotation.sessionFile }
+        ...(postCompactionSessionFile !== params.params.sessionFile
+          ? { sessionFile: postCompactionSessionFile }
           : {}),
       },
     };
