test: clarify update runner command assertions

shakkernerd · shakkernerd · commit 838565fe5997 · 2026-05-08T10:29:55.000+01:00
diff --git a/src/infra/update-runner.test.ts b/src/infra/update-runner.test.ts
@@ -323,7 +323,7 @@ describe("runGatewayUpdate", () => {
 
     expect(result.status).toBe("skipped");
     expect(result.reason).toBe("dirty");
-    expect(calls.some((call) => call.includes("rebase"))).toBe(false);
+    expect(calls).not.toEqual(expect.arrayContaining([expect.stringContaining("rebase")]));
   });
 
   it.each([
@@ -366,7 +366,7 @@ describe("runGatewayUpdate", () => {
 
     expect(result.status).toBe("error");
     expect(result.reason).toBe("rebase-failed");
-    expect(calls.some((call) => call.includes("rebase --abort"))).toBe(true);
+    expect(calls).toEqual(expect.arrayContaining([expect.stringContaining("rebase --abort")]));
   });
 
   it("returns error and stops early when deps install fails", async () => {
@@ -611,12 +611,16 @@ describe("runGatewayUpdate", () => {
     const result = await runWithCommand(runCommand, { channel: "dev" });
 
     expect(result.status).toBe("ok");
-    expect(calls.some((call) => call.startsWith("npm install --prefix "))).toBe(true);
+    expect(calls).toEqual(
+      expect.arrayContaining([expect.stringMatching(/^npm install --prefix /)]),
+    );
     expect(calls).toContain("pnpm install");
     expect(calls).toContain("pnpm build");
     expect(calls).not.toContain("pnpm lint");
     expect(calls).toContain("pnpm ui:build");
-    expect(pnpmEnvPaths.some((value) => value.includes("openclaw-update-pnpm-"))).toBe(true);
+    expect(pnpmEnvPaths).toEqual(
+      expect.arrayContaining([expect.stringContaining("openclaw-update-pnpm-")]),
+    );
   });
 
   it("runs dev preflight lint in constrained mode when explicitly enabled", async () => {
@@ -1961,7 +1965,9 @@ describe("runGatewayUpdate", () => {
 
     expect(result.status).toBe("error");
     expect(result.reason).toBe("not-openclaw-root");
-    expect(calls.some((call) => call.includes("status --porcelain"))).toBe(false);
+    expect(calls).not.toEqual(
+      expect.arrayContaining([expect.stringContaining("status --porcelain")]),
+    );
   });
 
   it("fails with a clear reason when openclaw.mjs is missing", async () => {
