test(agents): cover idle timeout fallback during tools

obviyus · obviyus · commit 7ffba2f3928a · 2026-05-13T13:00:17.000+05:30
diff --git a/src/agents/pi-embedded-runner/run/assistant-failover.ts b/src/agents/pi-embedded-runner/run/assistant-failover.ts
@@ -98,8 +98,8 @@ export async function handleAssistantFailover(params: {
 
   if (decision.action === "rotate_profile") {
     const failedProfileId = params.lastProfileId;
-    const failureReason =
-      params.timedOut || params.idleTimedOut ? "timeout" : params.assistantProfileFailureReason;
+    const timeoutFailure = params.timedOut || params.idleTimedOut;
+    const failureReason = timeoutFailure ? "timeout" : params.assistantProfileFailureReason;
     const markFailedProfile = async () => {
       if (!failedProfileId || !failureReason || failureReason === "timeout") {
         return;
@@ -155,11 +155,9 @@ export async function handleAssistantFailover(params: {
 
     const rotated = await params.advanceAuthProfile();
     const markFailedProfilePromise = markFailedProfile();
-    if (params.timedOut && !params.isProbeSession && failedProfileId) {
-      params.warn(`Profile ${failedProfileId} timed out. Trying next account...`);
-    }
-    if (params.idleTimedOut && !params.isProbeSession && failedProfileId) {
-      params.warn(`Profile ${failedProfileId} idle timeout (model silent). Trying next account...`);
+    if (timeoutFailure && !params.isProbeSession && failedProfileId) {
+      const timeoutLabel = params.idleTimedOut ? "idle timeout (model silent)" : "timed out";
+      params.warn(`Profile ${failedProfileId} ${timeoutLabel}. Trying next account...`);
     }
     if (params.cloudCodeAssistFormatError && failedProfileId) {
       params.warn(
@@ -289,6 +287,7 @@ function resolveAssistantFailoverErrorMessage(params: {
   billingFailure: boolean;
   authFailure: boolean;
 }): string {
+  const timeoutFailure = params.timedOut || params.idleTimedOut;
   return (
     (params.lastAssistant
       ? formatAssistantErrorText(params.lastAssistant, {
@@ -299,7 +298,7 @@ function resolveAssistantFailoverErrorMessage(params: {
         })
       : undefined) ||
     params.lastAssistant?.errorMessage?.trim() ||
-    (params.timedOut || params.idleTimedOut
+    (timeoutFailure
       ? "LLM request timed out."
       : params.rateLimitFailure
         ? "LLM request rate limited."
diff --git a/src/agents/pi-embedded-runner/run/failover-policy.test.ts b/src/agents/pi-embedded-runner/run/failover-policy.test.ts
@@ -279,6 +279,48 @@ describe("resolveRunFailoverDecision", () => {
     });
   });
 
+  it("treats idle watchdog timeouts during tool execution as model silence", () => {
+    expect(
+      resolveRunFailoverDecision({
+        stage: "assistant",
+        aborted: true,
+        externalAbort: false,
+        fallbackConfigured: true,
+        failoverFailure: false,
+        failoverReason: null,
+        timedOut: true,
+        idleTimedOut: true,
+        timedOutDuringCompaction: false,
+        timedOutDuringToolExecution: true,
+        profileRotated: false,
+      }),
+    ).toEqual({
+      action: "rotate_profile",
+      reason: null,
+    });
+  });
+
+  it("falls back after idle watchdog timeout during tool execution exhausts profile rotation", () => {
+    expect(
+      resolveRunFailoverDecision({
+        stage: "assistant",
+        aborted: true,
+        externalAbort: false,
+        fallbackConfigured: true,
+        failoverFailure: false,
+        failoverReason: null,
+        timedOut: true,
+        idleTimedOut: true,
+        timedOutDuringCompaction: false,
+        timedOutDuringToolExecution: true,
+        profileRotated: true,
+      }),
+    ).toEqual({
+      action: "fallback_model",
+      reason: "timeout",
+    });
+  });
+
   it("does not rotate or fallback assistant timeouts after an external abort", () => {
     expect(
       resolveRunFailoverDecision({
@@ -301,9 +343,6 @@ describe("resolveRunFailoverDecision", () => {
   });
 
   it("rotates profile on LLM idle timeout before falling back", () => {
-    // idleTimedOut = model produced no tokens; no provider API error was classified.
-    // Before this fix, failoverReason=null + timedOut=false → shouldRotateAssistant=false
-    // → continue_normal, causing a silent agent freeze.
     expect(
       resolveRunFailoverDecision({
         stage: "assistant",
diff --git a/src/agents/pi-embedded-runner/run/failover-policy.ts b/src/agents/pi-embedded-runner/run/failover-policy.ts
@@ -93,14 +93,20 @@ function shouldRotatePrompt(params: PromptDecisionParams): boolean {
   );
 }
 
+function isAssistantTimeoutFailure(params: AssistantDecisionParams): boolean {
+  return (
+    params.idleTimedOut ||
+    (params.timedOut && !params.timedOutDuringCompaction && !params.timedOutDuringToolExecution)
+  );
+}
+
 function shouldRotateAssistant(params: AssistantDecisionParams): boolean {
   if (isTerminalFormatFailure(params)) {
     return false;
   }
   return (
     (!params.aborted && (params.failoverFailure || params.failoverReason !== null)) ||
-    (params.timedOut && !params.timedOutDuringCompaction && !params.timedOutDuringToolExecution) ||
-    params.idleTimedOut
+    isAssistantTimeoutFailure(params)
   );
 }
 
@@ -180,8 +186,7 @@ export function resolveRunFailoverDecision(params: RunFailoverDecisionParams): R
   if (assistantShouldRotate && params.fallbackConfigured) {
     return {
       action: "fallback_model",
-      reason:
-        params.timedOut || params.idleTimedOut ? "timeout" : (params.failoverReason ?? "unknown"),
+      reason: isAssistantTimeoutFailure(params) ? "timeout" : (params.failoverReason ?? "unknown"),
     };
   }
   if (!assistantShouldRotate) {
